Re: [PATCH 2/5] drm/xe/xelp: Move Wa_16011163337 from tunings to workarounds

[Tvrtko Ursulin <tvrtko.ursulin@igalia.com>]

On 27/02/2025 20:58, Lucas De Marchi wrote:
> On Thu, Feb 27, 2025 at 10:13:01AM +0000, Tvrtko Ursulin wrote:
>> Workaround database specifies 16011163337 as a workaround so lets move it
>> there.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
>> ---
>> drivers/gpu/drm/xe/xe_tuning.c | 8 --------
>> drivers/gpu/drm/xe/xe_wa.c     | 7 +++++++
>> 2 files changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/ 
>> xe_tuning.c
>> index d449de0fb6ec..3c78f3d71559 100644
>> --- a/drivers/gpu/drm/xe/xe_tuning.c
>> +++ b/drivers/gpu/drm/xe/xe_tuning.c
>> @@ -97,14 +97,6 @@ static const struct xe_rtp_entry_sr 
>> engine_tunings[] = {
>> };
>>
>> static const struct xe_rtp_entry_sr lrc_tunings[] = {
>> -    { XE_RTP_NAME("Tuning: ganged timer, also known as 16011163337"),
> 
> we now lose the infor that we have this tuning implemented, but I'm ok
> with keeping it only on the WA side.... for newer platforms it's there
> so this is mostly making the older ones work.

Good point, and I am happy to respin with a reversed description like 
"16011163337, also known as Ganged timer tuning" or something.

Regards,

Tvrtko

> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
> 
> thanks
> Lucas De Marchi
> 
>> -      XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1210), 
>> ENGINE_CLASS(RENDER)),
>> -      /* read verification is ignored due to 1608008084. */
>> -      XE_RTP_ACTIONS(FIELD_SET_NO_READ_MASK(FF_MODE2,
>> -                        FF_MODE2_GS_TIMER_MASK,
>> -                        FF_MODE2_GS_TIMER_224))
>> -    },
>> -
>>     /* DG2 */
>>
>>     { XE_RTP_NAME("Tuning: L3 cache"),
>> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
>> index d4982799383c..e446bde3a52b 100644
>> --- a/drivers/gpu/drm/xe/xe_wa.c
>> +++ b/drivers/gpu/drm/xe/xe_wa.c
>> @@ -624,6 +624,13 @@ static const struct xe_rtp_entry_sr engine_was[] = {
>> };
>>
>> static const struct xe_rtp_entry_sr lrc_was[] = {
>> +    { XE_RTP_NAME("16011163337"),
>> +      XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1210), 
>> ENGINE_CLASS(RENDER)),
>> +      /* read verification is ignored due to 1608008084. */
>> +      XE_RTP_ACTIONS(FIELD_SET_NO_READ_MASK(FF_MODE2,
>> +                        FF_MODE2_GS_TIMER_MASK,
>> +                        FF_MODE2_GS_TIMER_224))
>> +    },
>>     { XE_RTP_NAME("1409342910, 14010698770, 14010443199, 1408979724, 
>> 1409178076, 1409207793, 1409217633, 1409252684, 1409347922, 1409142259"),
>>       XE_RTP_RULES(GRAPHICS_VERSION_RANGE(1200, 1210)),
>>       XE_RTP_ACTIONS(SET(COMMON_SLICE_CHICKEN3,
>> -- 
>> 2.48.0
>>