Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 0/5] Workaround fixes, improvements, additions
@ 2025-02-27 10:12 Tvrtko Ursulin
  2025-02-27 10:13 ` [PATCH 1/5] drm/xe: Fix GT "for each engine" workarounds Tvrtko Ursulin
                   ` (12 more replies)
  0 siblings, 13 replies; 23+ messages in thread
From: Tvrtko Ursulin @ 2025-02-27 10:12 UTC (permalink / raw)
  To: intel-xe
  Cc: kernel-dev, Tvrtko Ursulin, Lucas De Marchi, Matt Roper,
	Gustavo Sousa

A few things here:

1)
I think per engine GT workarounds are broken. None apply since engines are not
set up yet.

2)
I did a small audit of i915 vs xe workarounds and tunings with focus on ADL-P
and found some deltas. But without access to the internal database and even
up to date PRMs it is required if someone double checks the two.

Motivation being that there is some interest to make xe work on ADL-P as good as
possible.

3)
With the split between workarounds and tunings it feels useful to expose the
list of latter in debugfs too.

v2:
 * Attempt to fix first patch.
 * L3 hashing patch tidy.

v3:
 * New approach for "drm/xe: Fix GT "for each engine" workarounds".
 * Review comments for "drm/xe/gen12: L3 recommended hashing mask".

v4:
 * Move 16011163337 from tunings to workarounds in a separate patch.
 * Implement 1604555607 as a separate workaround.
 * Move "L3 recommended hashing mask" to an engine workaround.
 * Tidy naming s/gen12/xelp/.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Gustavo Sousa <gustavo.sousa@intel.com>

Tvrtko Ursulin (5):
  drm/xe: Fix GT "for each engine" workarounds
  drm/xe/xelp: Move Wa_16011163337 from tunings to workarounds
  drm/xe/xelp: Add Wa_1604555607
  drm/xe/xelp: L3 recommended hashing mask
  drm/xe: Add performance tunings to debugfs

 drivers/gpu/drm/xe/regs/xe_gt_regs.h |  5 +-
 drivers/gpu/drm/xe/xe_gt.c           |  8 +++-
 drivers/gpu/drm/xe/xe_gt_debugfs.c   | 11 +++++
 drivers/gpu/drm/xe/xe_gt_types.h     | 10 ++++
 drivers/gpu/drm/xe/xe_tuning.c       | 72 ++++++++++++++++++++++++----
 drivers/gpu/drm/xe/xe_tuning.h       |  3 ++
 drivers/gpu/drm/xe/xe_wa.c           | 14 ++++++
 7 files changed, 112 insertions(+), 11 deletions(-)

-- 
2.48.0


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2025-03-03 16:28 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-27 10:12 [PATCH v4 0/5] Workaround fixes, improvements, additions Tvrtko Ursulin
2025-02-27 10:13 ` [PATCH 1/5] drm/xe: Fix GT "for each engine" workarounds Tvrtko Ursulin
2025-02-27 10:13 ` [PATCH 2/5] drm/xe/xelp: Move Wa_16011163337 from tunings to workarounds Tvrtko Ursulin
2025-02-27 20:58   ` Lucas De Marchi
2025-02-28  8:08     ` Tvrtko Ursulin
2025-03-01  0:55       ` Lucas De Marchi
2025-02-27 10:13 ` [PATCH 3/5] drm/xe/xelp: Add Wa_1604555607 Tvrtko Ursulin
2025-02-27 21:13   ` Matt Roper
2025-02-27 21:13   ` Lucas De Marchi
2025-02-27 10:13 ` [PATCH 4/5] drm/xe/xelp: L3 recommended hashing mask Tvrtko Ursulin
2025-02-27 21:16   ` Lucas De Marchi
2025-02-27 21:21   ` Matt Roper
2025-03-01  5:48     ` Lucas De Marchi
2025-03-03 16:28       ` Tvrtko Ursulin
2025-02-27 10:13 ` [PATCH 5/5] drm/xe: Add performance tunings to debugfs Tvrtko Ursulin
2025-02-27 10:54 ` ✓ CI.Patch_applied: success for Workaround fixes, improvements, additions (rev4) Patchwork
2025-02-27 10:54 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-27 10:55 ` ✓ CI.KUnit: success " Patchwork
2025-02-27 11:12 ` ✓ CI.Build: " Patchwork
2025-02-27 11:15 ` ✓ CI.Hooks: " Patchwork
2025-02-27 11:16 ` ✓ CI.checksparse: " Patchwork
2025-02-27 11:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-27 13:52 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox