Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Subject: [PATCH 4/5] drm/xe/vf: Stop applying save-restore MMIOs if VF
Date: Mon,  3 Mar 2025 18:35:21 +0100	[thread overview]
Message-ID: <20250303173522.1822-5-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20250303173522.1822-1-michal.wajdeczko@intel.com>

Currently we are blocking processing of all save-restore rules
by the VFs inside the xe_rtp_process_to_sr() function, but we
want to unblock that to allow processing of the LRC WA rules.

To avoid hitting WARNs about reading an inaccessible registers by
the VFs, stop applying save-restore MMIOs action if VF, without
relying that SR list will be always empty for the VF.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_reg_sr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_reg_sr.c b/drivers/gpu/drm/xe/xe_reg_sr.c
index 9475e3f74958..fc8447a838c4 100644
--- a/drivers/gpu/drm/xe/xe_reg_sr.c
+++ b/drivers/gpu/drm/xe/xe_reg_sr.c
@@ -173,6 +173,9 @@ void xe_reg_sr_apply_mmio(struct xe_reg_sr *sr, struct xe_gt *gt)
 	if (xa_empty(&sr->xa))
 		return;
 
+	if (IS_SRIOV_VF(gt_to_xe(gt)))
+		return;
+
 	xe_gt_dbg(gt, "Applying %s save-restore MMIOs\n", sr->name);
 
 	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
-- 
2.47.1


  parent reply	other threads:[~2025-03-03 17:35 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 17:35 [PATCH 0/5] Use MI_MATH to apply RMW WA in LRC Michal Wajdeczko
2025-03-03 17:35 ` [PATCH 1/5] drm/xe: Add MI_LOAD_REGISTER_REG command definition Michal Wajdeczko
2025-03-03 21:18   ` Matt Roper
2025-03-03 17:35 ` [PATCH 2/5] drm/xe: Add MI_MATH and ALU instruction definitions Michal Wajdeczko
2025-03-03 21:50   ` Matt Roper
2025-03-04 16:23   ` [PATCH v2 " Michal Wajdeczko
2025-03-03 17:35 ` [PATCH 3/5] drm/xe: Avoid reading RMW registers in emit_wa_job Michal Wajdeczko
2025-03-03 18:06   ` Lucas De Marchi
2025-03-03 18:47     ` Michal Wajdeczko
2025-03-04 16:50       ` Lucas De Marchi
2025-03-03 22:06   ` Matt Roper
2025-03-03 17:35 ` Michal Wajdeczko [this message]
2025-03-03 18:09   ` [PATCH 4/5] drm/xe/vf: Stop applying save-restore MMIOs if VF Lucas De Marchi
2025-03-03 22:16     ` Matt Roper
2025-03-03 22:16   ` Matt Roper
2025-03-03 17:35 ` [PATCH 5/5] drm/xe/vf: Unblock xe_rtp_process_to_sr for VFs Michal Wajdeczko
2025-03-03 22:17   ` Matt Roper
2025-03-11 10:52   ` [PATCH v2 " Michal Wajdeczko
2025-03-03 17:44 ` ✓ CI.Patch_applied: success for Use MI_MATH to apply RMW WA in LRC Patchwork
2025-03-03 17:44 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-03 17:46 ` ✓ CI.KUnit: success " Patchwork
2025-03-03 18:02 ` ✓ CI.Build: " Patchwork
2025-03-03 18:05 ` ✓ CI.Hooks: " Patchwork
2025-03-03 18:06 ` ✓ CI.checksparse: " Patchwork
2025-03-03 18:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-03 20:12 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-04 17:27 ` ✓ CI.Patch_applied: success for Use MI_MATH to apply RMW WA in LRC (rev2) Patchwork
2025-03-04 17:27 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-04 17:28 ` ✓ CI.KUnit: success " Patchwork
2025-03-04 17:45 ` ✓ CI.Build: " Patchwork
2025-03-04 17:47 ` ✓ CI.Hooks: " Patchwork
2025-03-04 17:48 ` ✓ CI.checksparse: " Patchwork
2025-03-05  5:43 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-03-07 16:34   ` Michal Wajdeczko
2025-03-07 18:12 ` ✓ CI.Patch_applied: success for Use MI_MATH to apply RMW WA in LRC (rev3) Patchwork
2025-03-07 18:13 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-07 18:14 ` ✓ CI.KUnit: success " Patchwork
2025-03-07 18:36 ` ✓ CI.Build: " Patchwork
2025-03-07 18:39 ` ✓ CI.Hooks: " Patchwork
2025-03-07 18:41 ` ✓ CI.checksparse: " Patchwork
2025-03-07 19:03 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-08 20:46 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-10 16:31   ` Michal Wajdeczko
2025-03-11 12:55 ` ✓ CI.Patch_applied: success for Use MI_MATH to apply RMW WA in LRC (rev4) Patchwork
2025-03-11 12:55 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-11 12:56 ` ✓ CI.KUnit: success " Patchwork
2025-03-11 13:13 ` ✓ CI.Build: " Patchwork
2025-03-11 13:15 ` ✓ CI.Hooks: " Patchwork
2025-03-11 13:17 ` ✓ CI.checksparse: " Patchwork
2025-03-11 13:37 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-12  5:41 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-12 10:34   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250303173522.1822-5-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox