Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: intel-xe@lists.freedesktop.org
Cc: kernel-dev@igalia.com, Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH 1/4] drm/xe: Fix MOCS debugfs LNCF readout
Date: Fri,  7 Mar 2025 11:13:59 +0000	[thread overview]
Message-ID: <20250307111402.26577-2-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20250307111402.26577-1-tvrtko.ursulin@igalia.com>

With only XE_FW_GT taken LNCF registers read back as all zeroes, leading
to a wild goose chase trying to figure out why is register programming
incorrect.

Fix it by grabbing XE_FORCEWAKE_ALL for affected platforms.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_mocs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_mocs.c b/drivers/gpu/drm/xe/xe_mocs.c
index 54d199b5cfb2..31dade91a089 100644
--- a/drivers/gpu/drm/xe/xe_mocs.c
+++ b/drivers/gpu/drm/xe/xe_mocs.c
@@ -781,7 +781,9 @@ void xe_mocs_dump(struct xe_gt *gt, struct drm_printer *p)
 	flags = get_mocs_settings(xe, &table);
 
 	xe_pm_runtime_get_noresume(xe);
-	fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
+	fw_ref = xe_force_wake_get(gt_to_fw(gt),
+				   flags & HAS_LNCF_MOCS ?
+				   XE_FORCEWAKE_ALL : XE_FW_GT);
 	if (!fw_ref)
 		goto err_fw;
 
-- 
2.48.0


  reply	other threads:[~2025-03-07 11:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 11:13 [CI 0/4] Misc reviewed patches for CI Tvrtko Ursulin
2025-03-07 11:13 ` Tvrtko Ursulin [this message]
2025-03-07 11:14 ` [PATCH 2/4] drm/xe: Fix ring flush invalidation Tvrtko Ursulin
2025-03-07 11:14 ` [PATCH 3/4] drm/xe: Pass flags directly to emit_flush_imm_ggtt Tvrtko Ursulin
2025-03-07 12:26   ` Upadhyay, Tejas
2025-03-07 11:14 ` [PATCH 4/4] drm/xe: Use correct type width for alignment in fb pinning code Tvrtko Ursulin
2025-03-07 12:02 ` ✓ CI.Patch_applied: success for Misc reviewed patches for CI Patchwork
2025-03-07 12:03 ` ✓ CI.checkpatch: " Patchwork
2025-03-07 12:04 ` ✓ CI.KUnit: " Patchwork
2025-03-07 12:21 ` ✓ CI.Build: " Patchwork
2025-03-07 12:23 ` ✓ CI.Hooks: " Patchwork
2025-03-07 12:24 ` ✓ CI.checksparse: " Patchwork
2025-03-07 12:46 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-08  6:06 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-10 15:51 ` [CI 0/4] " Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307111402.26577-2-tvrtko.ursulin@igalia.com \
    --to=tvrtko.ursulin@igalia.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=kernel-dev@igalia.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox