From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [CI 01/14] drm/xe: Use xe_ggtt_map_bo_unlocked for resume
Date: Mon, 7 Apr 2025 15:04:36 +0200 [thread overview]
Message-ID: <20250407130449.1010470-2-dev@lankhorst.se> (raw)
In-Reply-To: <20250407130449.1010470-1-dev@lankhorst.se>
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
This is the first step to hide the details of struct xe_ggtt.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/xe/xe_bo_evict.c | 4 +---
drivers/gpu/drm/xe/xe_ggtt.c | 16 +++++++++++++++-
drivers/gpu/drm/xe/xe_ggtt.h | 2 +-
3 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_bo_evict.c b/drivers/gpu/drm/xe/xe_bo_evict.c
index a1f0661e7b0c8..b72d87d969930 100644
--- a/drivers/gpu/drm/xe/xe_bo_evict.c
+++ b/drivers/gpu/drm/xe/xe_bo_evict.c
@@ -129,9 +129,7 @@ static int xe_bo_restore_and_map_ggtt(struct xe_bo *bo)
if (tile != bo->tile && !(bo->flags & XE_BO_FLAG_GGTTx(tile)))
continue;
- mutex_lock(&tile->mem.ggtt->lock);
- xe_ggtt_map_bo(tile->mem.ggtt, bo);
- mutex_unlock(&tile->mem.ggtt->lock);
+ xe_ggtt_map_bo_unlocked(tile->mem.ggtt, bo);
}
}
diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
index 5fcb2b4c2c139..62025d9cb7380 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.c
+++ b/drivers/gpu/drm/xe/xe_ggtt.c
@@ -591,7 +591,7 @@ bool xe_ggtt_node_allocated(const struct xe_ggtt_node *node)
* @ggtt: the &xe_ggtt where node will be mapped
* @bo: the &xe_bo to be mapped
*/
-void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_bo *bo)
+static void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_bo *bo)
{
u16 cache_mode = bo->flags & XE_BO_FLAG_NEEDS_UC ? XE_CACHE_NONE : XE_CACHE_WB;
u16 pat_index = tile_to_xe(ggtt->tile)->pat.idx[cache_mode];
@@ -609,6 +609,20 @@ void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_bo *bo)
}
}
+/**
+ * xe_ggtt_map_bo_unlocked - Restore a mapping of a BO into GGTT
+ * @ggtt: the &xe_ggtt where node will be mapped
+ * @bo: the &xe_bo to be mapped
+ *
+ * This is used to restore a GGTT mapping after suspend.
+ */
+void xe_ggtt_map_bo_unlocked(struct xe_ggtt *ggtt, struct xe_bo *bo)
+{
+ mutex_lock(&ggtt->lock);
+ xe_ggtt_map_bo(ggtt, bo);
+ mutex_unlock(&ggtt->lock);
+}
+
static int __xe_ggtt_insert_bo_at(struct xe_ggtt *ggtt, struct xe_bo *bo,
u64 start, u64 end)
{
diff --git a/drivers/gpu/drm/xe/xe_ggtt.h b/drivers/gpu/drm/xe/xe_ggtt.h
index 27e7d67de0047..bdf6d0733e2ca 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.h
+++ b/drivers/gpu/drm/xe/xe_ggtt.h
@@ -24,7 +24,7 @@ int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node,
u32 size, u32 align, u32 mm_flags);
void xe_ggtt_node_remove(struct xe_ggtt_node *node, bool invalidate);
bool xe_ggtt_node_allocated(const struct xe_ggtt_node *node);
-void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_bo *bo);
+void xe_ggtt_map_bo_unlocked(struct xe_ggtt *ggtt, struct xe_bo *bo);
int xe_ggtt_insert_bo(struct xe_ggtt *ggtt, struct xe_bo *bo);
int xe_ggtt_insert_bo_at(struct xe_ggtt *ggtt, struct xe_bo *bo,
u64 start, u64 end);
--
2.45.2
next prev parent reply other threads:[~2025-04-07 13:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 13:04 [CI 00/14] drm/xe: Use migration for display GGTT updates Maarten Lankhorst
2025-04-07 13:04 ` Maarten Lankhorst [this message]
2025-04-07 13:04 ` [CI 02/14] drm/xe: Add xe_ggtt_might_lock Maarten Lankhorst
2025-04-07 13:04 ` [CI 03/14] drm/xe: Add xe_ggtt_alloc Maarten Lankhorst
2025-04-07 13:04 ` [CI 04/14] drm/xe/display: Remove dereferences of ggtt for tile id Maarten Lankhorst
2025-04-07 13:04 ` [CI 05/14] drm/xe/ggtt: Seperate flags and address in PTE encoding Maarten Lankhorst
2025-04-07 13:04 ` [CI 06/14] drm/xe/display: Dont poke into GGTT internals to fill a DPT Maarten Lankhorst
2025-04-07 13:04 ` [CI 07/14] drm/xe/display: Convert GGTT mapping to use pte_encode_flags Maarten Lankhorst
2025-04-07 13:04 ` [CI 08/14] drm/xe: Remove pte_encode_bo callback Maarten Lankhorst
2025-04-07 13:04 ` [CI 09/14] drm/xe: Implement a helper for reading out a GGTT PTE at a specified offset Maarten Lankhorst
2025-04-07 13:04 ` [CI 10/14] drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit tests Maarten Lankhorst
2025-04-07 13:04 ` [CI 11/14] drm/xe: Add GGTT updates to migration engine Maarten Lankhorst
2025-04-07 13:04 ` [CI 12/14] drm/xe: Convert xe_fb_pin to use a callback for insertion into GGTT Maarten Lankhorst
2025-04-07 13:04 ` [CI 13/14] drm/xe: Allow for optimization of xe_ggtt_map_bo Maarten Lankhorst
2025-04-07 13:04 ` [CI 14/14] drm/xe: Move struct xe_ggtt to xe_ggtt.c Maarten Lankhorst
2025-04-07 14:28 ` ✓ CI.Patch_applied: success for drm/xe: Use migration for display GGTT updates Patchwork
2025-04-07 14:28 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-07 14:29 ` ✓ CI.KUnit: success " Patchwork
2025-04-07 14:33 ` ✗ CI.Build: failure " Patchwork
2025-04-09 12:18 ` ✓ CI.Patch_applied: success for drm/xe: Use migration for display GGTT updates. (rev2) Patchwork
2025-04-09 12:19 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-09 12:20 ` ✓ CI.KUnit: success " Patchwork
2025-04-09 12:36 ` ✓ CI.Build: " Patchwork
2025-04-09 12:38 ` ✗ CI.Hooks: failure " Patchwork
2025-04-09 12:40 ` ✓ CI.checksparse: success " Patchwork
2025-04-09 13:31 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-10 4:56 ` ✗ Xe.CI.BAT: " Patchwork
2025-04-10 6:12 ` ✓ CI.Patch_applied: success " Patchwork
2025-04-10 6:13 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-10 6:14 ` ✓ CI.KUnit: success " Patchwork
2025-04-10 6:22 ` ✓ CI.Build: " Patchwork
2025-04-10 6:38 ` ✓ CI.Patch_applied: " Patchwork
2025-04-10 6:38 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-10 6:39 ` ✓ CI.KUnit: success " Patchwork
2025-04-10 6:48 ` ✓ CI.Build: " Patchwork
2025-04-10 6:50 ` ✗ CI.Hooks: failure " Patchwork
2025-04-10 6:51 ` ✓ CI.checksparse: success " Patchwork
2025-04-10 7:07 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-04-10 7:58 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407130449.1010470-2-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox