Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>
Subject: [CI 08/14] drm/xe: Remove pte_encode_bo callback
Date: Mon,  7 Apr 2025 15:04:43 +0200	[thread overview]
Message-ID: <20250407130449.1010470-9-dev@lankhorst.se> (raw)
In-Reply-To: <20250407130449.1010470-1-dev@lankhorst.se>

The users inside display have been converted to use thepte_encode_flags
callback, we can now remove the pte_encode_bo cb.

Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/xe/xe_ggtt.c       | 14 --------------
 drivers/gpu/drm/xe/xe_ggtt_types.h |  3 ---
 2 files changed, 17 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
index 5ea2f9fac85d4..36d3a0d6aa24a 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.c
+++ b/drivers/gpu/drm/xe/xe_ggtt.c
@@ -75,11 +75,6 @@ static u64 xelp_ggtt_pte_flags(struct xe_bo *bo, u16 pat_index)
 	return pte;
 }
 
-static u64 xelp_ggtt_encode_bo(struct xe_bo *bo, u64 bo_offset, u16 pat_index)
-{
-	return xelp_ggtt_pte_flags(bo, pat_index) | xe_bo_addr(bo, bo_offset, XE_PAGE_SIZE);
-}
-
 static u64 xelpg_ggtt_pte_flags(struct xe_bo *bo, u16 pat_index)
 {
 	struct xe_device *xe = xe_bo_device(bo);
@@ -98,12 +93,6 @@ static u64 xelpg_ggtt_pte_flags(struct xe_bo *bo, u16 pat_index)
 	return pte;
 }
 
-static u64 xelpg_ggtt_encode_bo(struct xe_bo *bo, u64 bo_offset,
-				u16 pat_index)
-{
-	return xelpg_ggtt_pte_flags(bo, pat_index) | xe_bo_addr(bo, bo_offset, XE_PAGE_SIZE);
-}
-
 static unsigned int probe_gsm_size(struct pci_dev *pdev)
 {
 	u16 gmch_ctl, ggms;
@@ -218,19 +207,16 @@ static void primelockdep(struct xe_ggtt *ggtt)
 }
 
 static const struct xe_ggtt_pt_ops xelp_pt_ops = {
-	.pte_encode_bo = xelp_ggtt_encode_bo,
 	.pte_encode_flags = xelp_ggtt_pte_flags,
 	.ggtt_set_pte = xe_ggtt_set_pte,
 };
 
 static const struct xe_ggtt_pt_ops xelpg_pt_ops = {
-	.pte_encode_bo = xelpg_ggtt_encode_bo,
 	.pte_encode_flags = xelpg_ggtt_pte_flags,
 	.ggtt_set_pte = xe_ggtt_set_pte,
 };
 
 static const struct xe_ggtt_pt_ops xelpg_pt_wa_ops = {
-	.pte_encode_bo = xelpg_ggtt_encode_bo,
 	.pte_encode_flags = xelpg_ggtt_pte_flags,
 	.ggtt_set_pte = xe_ggtt_set_pte_and_flush,
 };
diff --git a/drivers/gpu/drm/xe/xe_ggtt_types.h b/drivers/gpu/drm/xe/xe_ggtt_types.h
index 06b1a602dd8d1..c5e999d58ff2a 100644
--- a/drivers/gpu/drm/xe/xe_ggtt_types.h
+++ b/drivers/gpu/drm/xe/xe_ggtt_types.h
@@ -74,9 +74,6 @@ struct xe_ggtt_node {
  * Which can vary from platform to platform.
  */
 struct xe_ggtt_pt_ops {
-	/** @pte_encode_bo: Encode PTE flags for a given BO */
-	u64 (*pte_encode_bo)(struct xe_bo *bo, u64 bo_offset, u16 pat_index);
-
 	/** @pte_encode_flags: Encode PTE flags for a given BO */
 	u64 (*pte_encode_flags)(struct xe_bo *bo, u16 pat_index);
 	/** @ggtt_set_pte: Directly write into GGTT's PTE */
-- 
2.45.2


  parent reply	other threads:[~2025-04-07 13:05 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 13:04 [CI 00/14] drm/xe: Use migration for display GGTT updates Maarten Lankhorst
2025-04-07 13:04 ` [CI 01/14] drm/xe: Use xe_ggtt_map_bo_unlocked for resume Maarten Lankhorst
2025-04-07 13:04 ` [CI 02/14] drm/xe: Add xe_ggtt_might_lock Maarten Lankhorst
2025-04-07 13:04 ` [CI 03/14] drm/xe: Add xe_ggtt_alloc Maarten Lankhorst
2025-04-07 13:04 ` [CI 04/14] drm/xe/display: Remove dereferences of ggtt for tile id Maarten Lankhorst
2025-04-07 13:04 ` [CI 05/14] drm/xe/ggtt: Seperate flags and address in PTE encoding Maarten Lankhorst
2025-04-07 13:04 ` [CI 06/14] drm/xe/display: Dont poke into GGTT internals to fill a DPT Maarten Lankhorst
2025-04-07 13:04 ` [CI 07/14] drm/xe/display: Convert GGTT mapping to use pte_encode_flags Maarten Lankhorst
2025-04-07 13:04 ` Maarten Lankhorst [this message]
2025-04-07 13:04 ` [CI 09/14] drm/xe: Implement a helper for reading out a GGTT PTE at a specified offset Maarten Lankhorst
2025-04-07 13:04 ` [CI 10/14] drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit tests Maarten Lankhorst
2025-04-07 13:04 ` [CI 11/14] drm/xe: Add GGTT updates to migration engine Maarten Lankhorst
2025-04-07 13:04 ` [CI 12/14] drm/xe: Convert xe_fb_pin to use a callback for insertion into GGTT Maarten Lankhorst
2025-04-07 13:04 ` [CI 13/14] drm/xe: Allow for optimization of xe_ggtt_map_bo Maarten Lankhorst
2025-04-07 13:04 ` [CI 14/14] drm/xe: Move struct xe_ggtt to xe_ggtt.c Maarten Lankhorst
2025-04-07 14:28 ` ✓ CI.Patch_applied: success for drm/xe: Use migration for display GGTT updates Patchwork
2025-04-07 14:28 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-07 14:29 ` ✓ CI.KUnit: success " Patchwork
2025-04-07 14:33 ` ✗ CI.Build: failure " Patchwork
2025-04-09 12:18 ` ✓ CI.Patch_applied: success for drm/xe: Use migration for display GGTT updates. (rev2) Patchwork
2025-04-09 12:19 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-09 12:20 ` ✓ CI.KUnit: success " Patchwork
2025-04-09 12:36 ` ✓ CI.Build: " Patchwork
2025-04-09 12:38 ` ✗ CI.Hooks: failure " Patchwork
2025-04-09 12:40 ` ✓ CI.checksparse: success " Patchwork
2025-04-09 13:31 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-10  4:56 ` ✗ Xe.CI.BAT: " Patchwork
2025-04-10  6:12 ` ✓ CI.Patch_applied: success " Patchwork
2025-04-10  6:13 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-10  6:14 ` ✓ CI.KUnit: success " Patchwork
2025-04-10  6:22 ` ✓ CI.Build: " Patchwork
2025-04-10  6:38 ` ✓ CI.Patch_applied: " Patchwork
2025-04-10  6:38 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-10  6:39 ` ✓ CI.KUnit: success " Patchwork
2025-04-10  6:48 ` ✓ CI.Build: " Patchwork
2025-04-10  6:50 ` ✗ CI.Hooks: failure " Patchwork
2025-04-10  6:51 ` ✓ CI.checksparse: success " Patchwork
2025-04-10  7:07 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-04-10  7:58 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407130449.1010470-9-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox