Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Matthew Brost <matthew.brost@intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [CI 03/14] drm/xe: Add xe_ggtt_alloc
Date: Mon,  7 Apr 2025 15:04:38 +0200	[thread overview]
Message-ID: <20250407130449.1010470-4-dev@lankhorst.se> (raw)
In-Reply-To: <20250407130449.1010470-1-dev@lankhorst.se>

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Instead of allocating inside xe_tile, create a new function that returns
an allocated struct xe_ggtt from xe_ggtt.c

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/xe_ggtt.c | 16 ++++++++++++++++
 drivers/gpu/drm/xe/xe_ggtt.h |  2 ++
 drivers/gpu/drm/xe/xe_tile.c |  6 +-----
 3 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
index 5f4be9f40c9ba..b197b835ed442 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.c
+++ b/drivers/gpu/drm/xe/xe_ggtt.c
@@ -160,6 +160,22 @@ static void xe_ggtt_clear(struct xe_ggtt *ggtt, u64 start, u64 size)
 	}
 }
 
+/**
+ * xe_ggtt_alloc - Allocate a GGTT for a given &xe_tile
+ * @tile: &xe_tile
+ *
+ * Allocates a &xe_ggtt for a given tile.
+ *
+ * Return: &xe_ggtt on success, or NULL when out of memory.
+ */
+struct xe_ggtt *xe_ggtt_alloc(struct xe_tile *tile)
+{
+	struct xe_ggtt *ggtt = drmm_kzalloc(&tile_to_xe(tile)->drm, sizeof(*ggtt), GFP_KERNEL);
+	if (ggtt)
+		ggtt->tile = tile;
+	return ggtt;
+}
+
 static void ggtt_fini_early(struct drm_device *drm, void *arg)
 {
 	struct xe_ggtt *ggtt = arg;
diff --git a/drivers/gpu/drm/xe/xe_ggtt.h b/drivers/gpu/drm/xe/xe_ggtt.h
index 62c8ce636939a..0bab1fd7cc817 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.h
+++ b/drivers/gpu/drm/xe/xe_ggtt.h
@@ -9,7 +9,9 @@
 #include "xe_ggtt_types.h"
 
 struct drm_printer;
+struct xe_tile;
 
+struct xe_ggtt *xe_ggtt_alloc(struct xe_tile *tile);
 int xe_ggtt_init_early(struct xe_ggtt *ggtt);
 int xe_ggtt_init(struct xe_ggtt *ggtt);
 
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index 6f303d4097d6e..86e9811e60ba0 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -88,13 +88,9 @@
  */
 static int xe_tile_alloc(struct xe_tile *tile)
 {
-	struct drm_device *drm = &tile_to_xe(tile)->drm;
-
-	tile->mem.ggtt = drmm_kzalloc(drm, sizeof(*tile->mem.ggtt),
-				      GFP_KERNEL);
+	tile->mem.ggtt = xe_ggtt_alloc(tile);
 	if (!tile->mem.ggtt)
 		return -ENOMEM;
-	tile->mem.ggtt->tile = tile;
 
 	return 0;
 }
-- 
2.45.2


  parent reply	other threads:[~2025-04-07 13:05 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 13:04 [CI 00/14] drm/xe: Use migration for display GGTT updates Maarten Lankhorst
2025-04-07 13:04 ` [CI 01/14] drm/xe: Use xe_ggtt_map_bo_unlocked for resume Maarten Lankhorst
2025-04-07 13:04 ` [CI 02/14] drm/xe: Add xe_ggtt_might_lock Maarten Lankhorst
2025-04-07 13:04 ` Maarten Lankhorst [this message]
2025-04-07 13:04 ` [CI 04/14] drm/xe/display: Remove dereferences of ggtt for tile id Maarten Lankhorst
2025-04-07 13:04 ` [CI 05/14] drm/xe/ggtt: Seperate flags and address in PTE encoding Maarten Lankhorst
2025-04-07 13:04 ` [CI 06/14] drm/xe/display: Dont poke into GGTT internals to fill a DPT Maarten Lankhorst
2025-04-07 13:04 ` [CI 07/14] drm/xe/display: Convert GGTT mapping to use pte_encode_flags Maarten Lankhorst
2025-04-07 13:04 ` [CI 08/14] drm/xe: Remove pte_encode_bo callback Maarten Lankhorst
2025-04-07 13:04 ` [CI 09/14] drm/xe: Implement a helper for reading out a GGTT PTE at a specified offset Maarten Lankhorst
2025-04-07 13:04 ` [CI 10/14] drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit tests Maarten Lankhorst
2025-04-07 13:04 ` [CI 11/14] drm/xe: Add GGTT updates to migration engine Maarten Lankhorst
2025-04-07 13:04 ` [CI 12/14] drm/xe: Convert xe_fb_pin to use a callback for insertion into GGTT Maarten Lankhorst
2025-04-07 13:04 ` [CI 13/14] drm/xe: Allow for optimization of xe_ggtt_map_bo Maarten Lankhorst
2025-04-07 13:04 ` [CI 14/14] drm/xe: Move struct xe_ggtt to xe_ggtt.c Maarten Lankhorst
2025-04-07 14:28 ` ✓ CI.Patch_applied: success for drm/xe: Use migration for display GGTT updates Patchwork
2025-04-07 14:28 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-07 14:29 ` ✓ CI.KUnit: success " Patchwork
2025-04-07 14:33 ` ✗ CI.Build: failure " Patchwork
2025-04-09 12:18 ` ✓ CI.Patch_applied: success for drm/xe: Use migration for display GGTT updates. (rev2) Patchwork
2025-04-09 12:19 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-09 12:20 ` ✓ CI.KUnit: success " Patchwork
2025-04-09 12:36 ` ✓ CI.Build: " Patchwork
2025-04-09 12:38 ` ✗ CI.Hooks: failure " Patchwork
2025-04-09 12:40 ` ✓ CI.checksparse: success " Patchwork
2025-04-09 13:31 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-10  4:56 ` ✗ Xe.CI.BAT: " Patchwork
2025-04-10  6:12 ` ✓ CI.Patch_applied: success " Patchwork
2025-04-10  6:13 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-10  6:14 ` ✓ CI.KUnit: success " Patchwork
2025-04-10  6:22 ` ✓ CI.Build: " Patchwork
2025-04-10  6:38 ` ✓ CI.Patch_applied: " Patchwork
2025-04-10  6:38 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-10  6:39 ` ✓ CI.KUnit: success " Patchwork
2025-04-10  6:48 ` ✓ CI.Build: " Patchwork
2025-04-10  6:50 ` ✗ CI.Hooks: failure " Patchwork
2025-04-10  6:51 ` ✓ CI.checksparse: success " Patchwork
2025-04-10  7:07 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-04-10  7:58 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407130449.1010470-4-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox