Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, ville.syrjala@intel.com
Subject: [PATCH v5 04/17] drm/i915/display: Add VRR DC balance registers
Date: Tue, 13 May 2025 10:46:47 +0530	[thread overview]
Message-ID: <20250513051700.507389-5-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20250513051700.507389-1-mitulkumar.ajitkumar.golani@intel.com>

Add VRR register offsets and bits to access DC Balance configuration.

--v2:
- Separate register definitions. (Ankit)
- Remove usage of dev_priv. (Jani, Nikula)

--v3:
- Convert register address offset, from capital to small. (Ankit)
- Move mask bits near to register offsets. (Ankit)

Co-authored-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr_regs.h | 48 +++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr_regs.h b/drivers/gpu/drm/i915/display/intel_vrr_regs.h
index 6ed0e0dc97e7..204d5b35bc4b 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr_regs.h
+++ b/drivers/gpu/drm/i915/display/intel_vrr_regs.h
@@ -9,6 +9,53 @@
 #include "intel_display_reg_defs.h"
 
 /* VRR registers */
+#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A		0x604d4
+#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_B		0x614d4
+#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_C		0x624d4
+#define _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_D		0x634d4
+#define TRANS_VRR_DCB_ADJ_FLIPLINE_CFG(display, \
+				       trans)	_MMIO_TRANS2(display, trans, \
+							     _TRANS_VRR_DCB_ADJ_FLIPLINE_CFG_A)
+#define  VRR_DCB_ADJ_FLIPLINE_CNT_MASK			REG_GENMASK(31, 24)
+#define  VRR_DCB_ADJ_FLIPLINE_MASK			REG_GENMASK(19, 0)
+
+#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_A			0x604d8
+#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_B			0x614d8
+#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_C			0x624d8
+#define _TRANS_VRR_DCB_ADJ_VMAX_CFG_D			0x634d8
+#define TRANS_VRR_DCB_ADJ_VMAX_CFG(display, trans)	_MMIO_TRANS2(display, \
+								     trans, \
+								     _TRANS_VRR_DCB_ADJ_VMAX_CFG_A)
+#define  VRR_DCB_ADJ_VMAX_CNT_MASK			REG_GENMASK(31, 24)
+#define  VRR_DCB_ADJ_VMAX_MASK				REG_GENMASK(19, 0)
+
+#define _TRANS_VRR_FLIPLINE_DCB_A			0x60418
+#define _TRANS_VRR_FLIPLINE_DCB_B			0x61418
+#define _TRANS_VRR_FLIPLINE_DCB_C			0x62418
+#define _TRANS_VRR_FLIPLINE_DCB_D			0x63418
+#define TRANS_VRR_FLIPLINE_DCB(display, trans)		_MMIO_TRANS2(display, \
+								     trans, \
+								     _TRANS_VRR_FLIPLINE_DCB_A)
+#define VRR_FLIPLINE_DCB_MASK				REG_GENMASK(19, 0)
+
+#define _TRANS_VRR_VMAX_DCB_A				0x60414
+#define _TRANS_VRR_VMAX_DCB_B				0x61414
+#define _TRANS_VRR_VMAX_DCB_C				0x62414
+#define _TRANS_VRR_VMAX_DCB_D				0x63414
+#define TRANS_VRR_VMAX_DCB(display, trans)		_MMIO_TRANS2(display, \
+								     trans, \
+								     _TRANS_VRR_VMAX_DCB_A)
+#define  VRR_VMAX_DCB_MASK				REG_GENMASK(19, 0)
+
+#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_A			0x604c0
+#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_B			0x614c0
+#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_C			0x624c0
+#define _TRANS_ADAPTIVE_SYNC_DCB_CTL_D			0x634c0
+#define TRANS_ADAPTIVE_SYNC_DCB_CTL(display, trans)	_MMIO_TRANS2(display, \
+								     trans, \
+								     _TRANS_ADAPTIVE_SYNC_DCB_CTL_A)
+#define ADAPTIVE_SYNC_COUNTER_EN			REG_BIT(31)
+
 #define _TRANS_VRR_CTL_A			0x60420
 #define _TRANS_VRR_CTL_B			0x61420
 #define _TRANS_VRR_CTL_C			0x62420
@@ -20,6 +67,7 @@
 #define  VRR_CTL_PIPELINE_FULL_MASK		REG_GENMASK(10, 3)
 #define  VRR_CTL_PIPELINE_FULL(x)		REG_FIELD_PREP(VRR_CTL_PIPELINE_FULL_MASK, (x))
 #define  VRR_CTL_PIPELINE_FULL_OVERRIDE		REG_BIT(0)
+#define  VRR_CTL_DCB_ADJ_ENABLE			REG_BIT(28)
 #define  XELPD_VRR_CTL_VRR_GUARDBAND_MASK	REG_GENMASK(15, 0)
 #define  XELPD_VRR_CTL_VRR_GUARDBAND(x)		REG_FIELD_PREP(XELPD_VRR_CTL_VRR_GUARDBAND_MASK, (x))
 
-- 
2.48.1


  parent reply	other threads:[~2025-05-13  5:19 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13  5:16 [PATCH v5 00/17] Enable/Disable DC balance along with VRR DSB Mitul Golani
2025-05-13  5:16 ` [PATCH v5 01/17] drm/i915/vrr: Refactor vmin/vmax stuff Mitul Golani
2025-05-13  5:16 ` [PATCH v5 02/17] drm/i915/display: Add source param for dc balance Mitul Golani
2025-05-13  5:16 ` [PATCH v5 03/17] drm/i915/display: Add pipe dmc registers and bits for DC Balance Mitul Golani
2025-05-30  6:22   ` Nautiyal, Ankit K
2025-05-13  5:16 ` Mitul Golani [this message]
2025-05-13  7:15   ` [PATCH v5 04/17] drm/i915/display: Add VRR DC balance registers Jani Nikula
2025-05-13  5:16 ` [PATCH v5 05/17] drm/i915/vrr: Add functions to read out vmin/vmax stuff Mitul Golani
2025-05-13  5:16 ` [PATCH v5 06/17] drm/i915/vrr: Add DC Balance params to crtc_state Mitul Golani
2025-05-13  5:16 ` [PATCH v5 07/17] drm/i915/vrr: Add state dump for DC Balance params Mitul Golani
2025-05-13  5:16 ` [PATCH v5 08/17] drm/i915/vrr: Add compute config " Mitul Golani
2025-05-13  5:16 ` [PATCH v5 09/17] drm/i915/vrr: Write DC balance params to hw registers Mitul Golani
2025-05-27  6:17   ` Nautiyal, Ankit K
2025-05-13  5:16 ` [PATCH v5 10/17] drm/i915: Extract vrr_vblank_start() Mitul Golani
2025-05-13  5:16 ` [PATCH v5 11/17] drm/i915/vrr: Implement vblank evasion with DC balancing Mitul Golani
2025-05-13  5:16 ` [PATCH v5 12/17] drm/i915/dsb: Add pipedmc dc balance enable/disable Mitul Golani
2025-05-13  5:16 ` [PATCH v5 13/17] drm/i915/vrr: Restructure VRR enablement bit Mitul Golani
2025-05-13  5:16 ` [PATCH v5 14/17] drm/i915/vrr: Pause DC Balancing for DSB commits Mitul Golani
2025-05-13  5:16 ` [PATCH v5 15/17] drm/i915/vrr: Add function to check if DC Balance Possible Mitul Golani
2025-05-13  5:16 ` [PATCH v5 16/17] drm/i915/display: Add function to configure PIPEDMC_EVT_CTL Mitul Golani
2025-05-13  5:17 ` [PATCH v5 17/17] drm/i915/vrr: Enable DC Balance bit Mitul Golani
2025-05-13  5:24 ` ✓ CI.Patch_applied: success for Enable/Disable DC balance along with VRR DSB (rev5) Patchwork
2025-05-13  5:25 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-13  5:26 ` ✓ CI.KUnit: success " Patchwork
2025-05-13  5:36 ` ✗ CI.Build: failure " Patchwork
2025-05-13 15:51 ` ✓ CI.Patch_applied: success " Patchwork
2025-05-13 15:51 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-13 15:52 ` ✓ CI.KUnit: success " Patchwork
2025-05-13 16:10 ` ✓ CI.Build: " Patchwork
2025-05-14 17:24 ` ✓ CI.Patch_applied: success for Enable/Disable DC balance along with VRR DSB (rev6) Patchwork
2025-05-14 17:24 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-14 17:25 ` ✓ CI.KUnit: success " Patchwork
2025-05-14 17:36 ` ✓ CI.Build: " Patchwork
2025-05-14 17:38 ` ✓ CI.Hooks: " Patchwork
2025-05-14 17:40 ` ✗ CI.checksparse: warning " Patchwork
2025-05-14 18:02 ` ✓ Xe.CI.BAT: success " Patchwork
2025-05-15  1:36 ` ✓ Xe.CI.Full: " Patchwork
2025-05-27  0:39 ` ✗ CI.Patch_applied: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513051700.507389-5-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox