From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH] drm/xe/pm: Correct comment of xe_pm_set_vram_threshold()
Date: Mon, 7 Jul 2025 02:15:11 +0000 [thread overview]
Message-ID: <20250707021510.3525028-2-shuicheng.lin@intel.com> (raw)
The parameter threshold is with size in mb, not in bits.
Correct it to avoid any confusion.
Fixes: 30c399529f4c ("drm/xe: Document Xe PM component")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
drivers/gpu/drm/xe/xe_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index bcfda545e74f..c7622e1c614b 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -754,7 +754,7 @@ void xe_pm_assert_unbounded_bridge(struct xe_device *xe)
/**
* xe_pm_set_vram_threshold - Set a vram threshold for allowing/blocking D3Cold
* @xe: xe device instance
- * @threshold: VRAM size in bites for the D3cold threshold
+ * @threshold: VRAM size in mb for the D3cold threshold
*
* Returns 0 for success, negative error code otherwise.
*/
--
2.49.0
next reply other threads:[~2025-07-07 2:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 2:15 Shuicheng Lin [this message]
2025-07-07 2:23 ` ✓ CI.KUnit: success for drm/xe/pm: Correct comment of xe_pm_set_vram_threshold() Patchwork
2025-07-07 17:42 ` [PATCH] " Michal Wajdeczko
2025-07-08 2:14 ` [PATCH v2] " Shuicheng Lin
2025-07-08 2:22 ` ✓ CI.KUnit: success for drm/xe/pm: Correct comment of xe_pm_set_vram_threshold() (rev2) Patchwork
2025-07-08 3:03 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-08 5:08 ` ✓ Xe.CI.Full: " Patchwork
2025-07-09 22:59 ` [PATCH] drm/xe/pm: Correct comment of xe_pm_set_vram_threshold() Summers, Stuart
2025-07-10 18:52 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707021510.3525028-2-shuicheng.lin@intel.com \
--to=shuicheng.lin@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox