Re: [PATCH] drm/xe/pm: Correct comment of xe_pm_set_vram_threshold()

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Jul 09, 2025 at 10:59:56PM +0000, Summers, Stuart wrote:
> On Mon, 2025-07-07 at 02:15 +0000, Shuicheng Lin wrote:
> > The parameter threshold is with size in mb, not in bits.
> > Correct it to avoid any confusion.
> > 
> > Fixes: 30c399529f4c ("drm/xe: Document Xe PM component")
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_pm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> > index bcfda545e74f..c7622e1c614b 100644
> > --- a/drivers/gpu/drm/xe/xe_pm.c
> > +++ b/drivers/gpu/drm/xe/xe_pm.c
> > @@ -754,7 +754,7 @@ void xe_pm_assert_unbounded_bridge(struct
> > xe_device *xe)
> >  /**
> >   * xe_pm_set_vram_threshold - Set a vram threshold for
> > allowing/blocking D3Cold
> >   * @xe: xe device instance
> > - * @threshold: VRAM size in bites for the D3cold threshold
> > + * @threshold: VRAM size in mb for the D3cold threshold
> 
> This matches the other checks in the same function and documentation in
> xe_pm.h. Thanks!
> 
> Reviewed-by: Stuart Summers <stuart.summers@intel.com>

pushed the v2 of this but keeping your reviewed-by tag since
it was minor but good changes.

Thanks,
Rodrigo

> 
> >   *
> >   * Returns 0 for success, negative error code otherwise.
> >   */
>