Re: [PATCH] drm/xe/pm: Correct comment of xe_pm_set_vram_threshold()

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 07.07.2025 04:15, Shuicheng Lin wrote:
> The parameter threshold is with size in mb, not in bits.

s/mb/MiB

> Correct it to avoid any confusion.
> 
> Fixes: 30c399529f4c ("drm/xe: Document Xe PM component")
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index bcfda545e74f..c7622e1c614b 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -754,7 +754,7 @@ void xe_pm_assert_unbounded_bridge(struct xe_device *xe)
>  /**
>   * xe_pm_set_vram_threshold - Set a vram threshold for allowing/blocking D3Cold

while around, please s/vram/VRAM

>   * @xe: xe device instance
> - * @threshold: VRAM size in bites for the D3cold threshold
> + * @threshold: VRAM size in mb for the D3cold threshold

s/mb/MiB

>   *
>   * Returns 0 for success, negative error code otherwise.

and also please fix return section according to [1]

[1] https://docs.kernel.org/doc-guide/kernel-doc.html#return-values

>   */