From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 00/14] Optimize vrr.guardband and fix LRR
Date: Sun, 7 Sep 2025 13:02:27 +0530 [thread overview]
Message-ID: <20250907073241.19632-1-ankit.k.nautiyal@intel.com> (raw)
Instead of setting vrr.guardband to vblank, use optimal guardband that
works for most of the cases. This will help in avoiding need of change
in guardband and fix the LRR feature that needs seamless switching to
a lower refresh rate.
First few patches fix/refactor and extract common functions required for
dsc/scaler prefill time computation. Later patches use these helpers to
compute an optimized guardband.
Also, for seamless_mn where vtotal is same but mode clock is changed to
seamlessly switch to lower rate, re-compute the vrr timings.
Few things that still need work:
-The timestamps corresponding with next start of vactive still need to be
fixed with the new scheme.
-Re-enabling CMRR
Rev2:
-Address comments from Mitul.
-Extract helpers for dsc/scaler prefill latencies.
-Fix downscaling factor for chroma subsampling.
-Use missing pkg C max latency.
-Fix guardband computation for seamless mn, always use vblank for
higher resolution.
Rev3:
-Drop patches for computing and storing PSR/Panel Replay wake times
latencies and use existing helpers to compute these in intel_alpm.c.
-Drop patch to change the Vmin as it was not required.
Rev4:
-Rebase
-Drop patch for checking bounds for scaler array access.
-Use a new flag for setting vrr timings for seamless drrs.
Rev5:
-Address comments from Mitul, Jani:
-Refactor few helpers for computing latencies.
-Rename the helper to check the guardband to intel_crtc_guardband_atomic_check()
-Refactor the helper intel_panel_highest_mode().
Rev6:
-Rebase
-Address review comments from Mitul.
-Improve documentation for and other minor fixes in Patch#12
Rev7:
-Address comments from Jani.
-Move the latency helpers from intel_display.c to intel_vrr.c and rename
the helpers appropriately.
-Drop redundant check for HAS_VRR with intel_vrr_possible().
Rev8:
-Fix CI issues.
-For fixed RR wait for delayed vblank before dsb interrupt.
Rev9:
-Fix vrr.vsync_start/end timings for 3D modes (patch#1)
-Rewrite the patch to wait for delayed vblank before dsb interrupt
(patch #11)
-Fix the flipline and vmin timings with optimized guardband (patch#12)
Ankit Nautiyal (14):
drm/i915/vrr: Use crtc_vsync_start/end for computing
vrr.vsync_start/end
drm/i915/skl_watermark: Fix the scaling factor for chroma subsampling
drm/i915/skl_watermark: Pass linetime as argument to latency helpers
drm/i915/skl_scaler: Introduce helper for chroma downscale factor
drm/i915/display: Extract helpers to set dsc/scaler prefill latencies
drm/i915/dp: Add SDP latency computation helper
drm/i915/alpm: Add function to compute max link-wake latency
drm/i915/vrr: Use vrr.sync_start for getting vtotal
drm/i915/display: Add guardband check for feature latencies
drm/i915/skl_watermark: Remove redundant latency checks from vblank
validation
drm/i915/dsb: Align flipdone with delayed vblank using guardband wait
drm/i915/vrr: Use static guardband to support seamless LRR switching
drm/i915/panel: Refactor helper to get highest fixed mode
drm/i915/vrr: Fix seamless_mn drrs for PTL
drivers/gpu/drm/i915/display/intel_alpm.c | 15 +
drivers/gpu/drm/i915/display/intel_alpm.h | 2 +
drivers/gpu/drm/i915/display/intel_display.c | 145 ++++++++-
.../drm/i915/display/intel_display_types.h | 2 +
drivers/gpu/drm/i915/display/intel_dp.c | 63 +++-
drivers/gpu/drm/i915/display/intel_dp.h | 2 +
drivers/gpu/drm/i915/display/intel_dsb.c | 16 +
drivers/gpu/drm/i915/display/intel_dsb.h | 3 +
drivers/gpu/drm/i915/display/intel_panel.c | 11 +-
drivers/gpu/drm/i915/display/intel_panel.h | 3 +-
drivers/gpu/drm/i915/display/intel_vrr.c | 275 ++++++++++++++++--
drivers/gpu/drm/i915/display/intel_vrr.h | 11 +-
drivers/gpu/drm/i915/display/skl_scaler.c | 5 +
drivers/gpu/drm/i915/display/skl_scaler.h | 3 +
drivers/gpu/drm/i915/display/skl_watermark.c | 89 +-----
drivers/gpu/drm/i915/display/skl_watermark.h | 1 +
16 files changed, 524 insertions(+), 122 deletions(-)
--
2.45.2
next reply other threads:[~2025-09-07 7:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 7:32 Ankit Nautiyal [this message]
2025-09-07 7:32 ` [PATCH 01/14] drm/i915/vrr: Use crtc_vsync_start/end for computing vrr.vsync_start/end Ankit Nautiyal
2025-09-08 8:08 ` Shankar, Uma
2025-09-07 7:32 ` [PATCH 02/14] drm/i915/skl_watermark: Fix the scaling factor for chroma subsampling Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 03/14] drm/i915/skl_watermark: Pass linetime as argument to latency helpers Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 04/14] drm/i915/skl_scaler: Introduce helper for chroma downscale factor Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 05/14] drm/i915/display: Extract helpers to set dsc/scaler prefill latencies Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 06/14] drm/i915/dp: Add SDP latency computation helper Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 07/14] drm/i915/alpm: Add function to compute max link-wake latency Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 08/14] drm/i915/vrr: Use vrr.sync_start for getting vtotal Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 09/14] drm/i915/display: Add guardband check for feature latencies Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 10/14] drm/i915/skl_watermark: Remove redundant latency checks from vblank validation Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 11/14] drm/i915/dsb: Align flipdone with delayed vblank using guardband wait Ankit Nautiyal
2025-09-08 8:05 ` Shankar, Uma
2025-09-07 7:32 ` [PATCH 12/14] drm/i915/vrr: Use static guardband to support seamless LRR switching Ankit Nautiyal
2025-09-08 16:43 ` Ville Syrjälä
2025-09-09 15:02 ` Nautiyal, Ankit K
2025-09-10 12:30 ` Ville Syrjälä
2025-09-10 13:37 ` Nautiyal, Ankit K
2025-09-07 7:32 ` [PATCH 13/14] drm/i915/panel: Refactor helper to get highest fixed mode Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 14/14] drm/i915/vrr: Fix seamless_mn drrs for PTL Ankit Nautiyal
2025-09-08 20:33 ` ✓ CI.KUnit: success for Optimize vrr.guardband and fix LRR (rev9) Patchwork
2025-09-09 0:38 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-09 1:09 ` ✓ CI.KUnit: success for Optimize vrr.guardband and fix LRR (rev10) Patchwork
2025-09-09 1:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-09 8:02 ` ✗ Xe.CI.Full: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-09-26 5:59 [PATCH 00/14] Optimize vrr.guardband and fix LRR Ankit Nautiyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250907073241.19632-1-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox