From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 11/14] drm/i915/dsb: Align flipdone with delayed vblank using guardband wait
Date: Sun, 7 Sep 2025 13:02:38 +0530 [thread overview]
Message-ID: <20250907073241.19632-12-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20250907073241.19632-1-ankit.k.nautiyal@intel.com>
Currently the guardband is same as vblank length and undelayed vblank
and the vblank and the flipdone with dsb interrupt are already aligned
for the fixed refresh rate case.
As we move towards a shorter optimized guardband we need to wait for the
delayed vblank before the DSB interrupt to align the flipdone event with
the delayed vblank.
Introduce a helper intel_dsb_wait_for_delayed_vblank() to wait for the
scanline range [delayed_vblank_start, vmin/vmax vtotal], depending on
whether fixed refresh rate mode or variable refresh rate mode is active,
before triggering the DSB interrupt.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 1 +
drivers/gpu/drm/i915/display/intel_dsb.c | 16 ++++++++++++++++
drivers/gpu/drm/i915/display/intel_dsb.h | 3 +++
3 files changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 787bb6ebdc75..fb072275b1c7 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7447,6 +7447,7 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
intel_vrr_send_push(new_crtc_state->dsb_commit, new_crtc_state);
intel_dsb_wait_vblank_delay(state, new_crtc_state->dsb_commit);
+ intel_dsb_wait_for_delayed_vblank(state, new_crtc_state->dsb_commit);
intel_vrr_check_push_sent(new_crtc_state->dsb_commit,
new_crtc_state);
intel_dsb_interrupt(new_crtc_state->dsb_commit);
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index dee44d45b668..6b3a4d25a6c6 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -1026,3 +1026,19 @@ void intel_dsb_irq_handler(struct intel_display *display,
drm_err(display->drm, "[CRTC:%d:%s] DSB %d GOSUB programming error\n",
crtc->base.base.id, crtc->base.name, dsb_id);
}
+
+void intel_dsb_wait_for_delayed_vblank(struct intel_atomic_state *state,
+ struct intel_dsb *dsb)
+{
+ const struct intel_crtc_state *crtc_state;
+ struct intel_crtc *crtc = dsb->crtc;
+ int start, end;
+
+ crtc_state = intel_pre_commit_crtc_state(state, crtc);
+ start = intel_vrr_vmin_vblank_start(crtc_state);
+ end = crtc_state->vrr.enable ?
+ intel_vrr_vmax_vtotal(crtc_state) :
+ intel_vrr_vmin_vtotal(crtc_state);
+
+ intel_dsb_wait_scanline_in(state, dsb, start, end);
+}
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
index c8f4499916eb..6eb810aad18f 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.h
+++ b/drivers/gpu/drm/i915/display/intel_dsb.h
@@ -74,4 +74,7 @@ void intel_dsb_wait(struct intel_dsb *dsb);
void intel_dsb_irq_handler(struct intel_display *display,
enum pipe pipe, enum intel_dsb_id dsb_id);
+void intel_dsb_wait_for_delayed_vblank(struct intel_atomic_state *state,
+ struct intel_dsb *dsb);
+
#endif
--
2.45.2
next prev parent reply other threads:[~2025-09-07 7:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 7:32 [PATCH 00/14] Optimize vrr.guardband and fix LRR Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 01/14] drm/i915/vrr: Use crtc_vsync_start/end for computing vrr.vsync_start/end Ankit Nautiyal
2025-09-08 8:08 ` Shankar, Uma
2025-09-07 7:32 ` [PATCH 02/14] drm/i915/skl_watermark: Fix the scaling factor for chroma subsampling Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 03/14] drm/i915/skl_watermark: Pass linetime as argument to latency helpers Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 04/14] drm/i915/skl_scaler: Introduce helper for chroma downscale factor Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 05/14] drm/i915/display: Extract helpers to set dsc/scaler prefill latencies Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 06/14] drm/i915/dp: Add SDP latency computation helper Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 07/14] drm/i915/alpm: Add function to compute max link-wake latency Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 08/14] drm/i915/vrr: Use vrr.sync_start for getting vtotal Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 09/14] drm/i915/display: Add guardband check for feature latencies Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 10/14] drm/i915/skl_watermark: Remove redundant latency checks from vblank validation Ankit Nautiyal
2025-09-07 7:32 ` Ankit Nautiyal [this message]
2025-09-08 8:05 ` [PATCH 11/14] drm/i915/dsb: Align flipdone with delayed vblank using guardband wait Shankar, Uma
2025-09-07 7:32 ` [PATCH 12/14] drm/i915/vrr: Use static guardband to support seamless LRR switching Ankit Nautiyal
2025-09-08 16:43 ` Ville Syrjälä
2025-09-09 15:02 ` Nautiyal, Ankit K
2025-09-10 12:30 ` Ville Syrjälä
2025-09-10 13:37 ` Nautiyal, Ankit K
2025-09-07 7:32 ` [PATCH 13/14] drm/i915/panel: Refactor helper to get highest fixed mode Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 14/14] drm/i915/vrr: Fix seamless_mn drrs for PTL Ankit Nautiyal
2025-09-08 20:33 ` ✓ CI.KUnit: success for Optimize vrr.guardband and fix LRR (rev9) Patchwork
2025-09-09 0:38 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-09 1:09 ` ✓ CI.KUnit: success for Optimize vrr.guardband and fix LRR (rev10) Patchwork
2025-09-09 1:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-09 8:02 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250907073241.19632-12-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox