From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com,
Ankit Nautiyal <ankit.k.nautiyal@intel.com>,
Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Subject: [PATCH 10/14] drm/i915/skl_watermark: Remove redundant latency checks from vblank validation
Date: Sun, 7 Sep 2025 13:02:37 +0530 [thread overview]
Message-ID: <20250907073241.19632-11-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20250907073241.19632-1-ankit.k.nautiyal@intel.com>
Drop DSC and scaler prefill latency checks from skl_is_vblank_too_short().
These are now covered by the guardband validation added during the atomic
CRTC check phase.
This cleanup prepares for future changes where the guardband will be
optimized independently of vblank length, making vblank-based checks
obsolete.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/display/skl_watermark.c | 79 --------------------
1 file changed, 79 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 83ac26004f05..07589096b143 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -28,7 +28,6 @@
#include "intel_flipq.h"
#include "intel_pcode.h"
#include "intel_plane.h"
-#include "intel_vrr.h"
#include "intel_wm.h"
#include "skl_universal_plane_regs.h"
#include "skl_scaler.h"
@@ -2159,93 +2158,15 @@ static int icl_build_plane_wm(struct intel_crtc_state *crtc_state,
return 0;
}
-static int
-cdclk_prefill_adjustment(const struct intel_crtc_state *crtc_state)
-{
- struct intel_display *display = to_intel_display(crtc_state);
- struct intel_atomic_state *state =
- to_intel_atomic_state(crtc_state->uapi.state);
- const struct intel_cdclk_state *cdclk_state;
-
- cdclk_state = intel_atomic_get_cdclk_state(state);
- if (IS_ERR(cdclk_state)) {
- drm_WARN_ON(display->drm, PTR_ERR(cdclk_state));
- return 1;
- }
-
- return min(1, DIV_ROUND_UP(crtc_state->pixel_rate,
- 2 * intel_cdclk_logical(cdclk_state)));
-}
-
-static int
-dsc_prefill_latency(const struct intel_crtc_state *crtc_state, int linetime)
-{
- const struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state;
- int chroma_downscaling_factor = skl_scaler_chroma_downscale_factor(crtc_state);
- struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
- int num_scaler_users = hweight32(scaler_state->scaler_users);
- u64 hscale_k[ARRAY_SIZE(scaler_state->scalers)];
- u64 vscale_k[ARRAY_SIZE(scaler_state->scalers)];
- u32 dsc_prefill_latency = 0;
-
- if (!crtc_state->dsc.compression_enable ||
- !num_scaler_users ||
- num_scaler_users > crtc->num_scalers)
- return dsc_prefill_latency;
-
- for (int i = 0; i < num_scaler_users; i++) {
- hscale_k[i] = max(1000, mul_u32_u32(scaler_state->scalers[i].hscale, 1000) >> 16);
- vscale_k[i] = max(1000, mul_u32_u32(scaler_state->scalers[i].vscale, 1000) >> 16);
- }
-
- dsc_prefill_latency =
- intel_vrr_guardband_dsc_latency(num_scaler_users, hscale_k, vscale_k,
- chroma_downscaling_factor,
- cdclk_prefill_adjustment(crtc_state),
- linetime);
-
- return dsc_prefill_latency;
-}
-
-static int
-scaler_prefill_latency(const struct intel_crtc_state *crtc_state, int linetime)
-{
- const struct intel_crtc_scaler_state *scaler_state = &crtc_state->scaler_state;
- int chroma_downscaling_factor = skl_scaler_chroma_downscale_factor(crtc_state);
- int num_scaler_users = hweight32(scaler_state->scaler_users);
- u64 hscale_k = 0, vscale_k = 0;
- int scaler_prefill_latency = 0;
-
- if (!num_scaler_users)
- return scaler_prefill_latency;
-
- if (num_scaler_users > 1) {
- hscale_k = max(1000, mul_u32_u32(scaler_state->scalers[0].hscale, 1000) >> 16);
- vscale_k = max(1000, mul_u32_u32(scaler_state->scalers[0].vscale, 1000) >> 16);
- }
-
- scaler_prefill_latency =
- intel_vrr_guardband_scaler_latency(num_scaler_users, hscale_k, vscale_k,
- chroma_downscaling_factor,
- cdclk_prefill_adjustment(crtc_state),
- linetime);
-
- return scaler_prefill_latency;
-}
-
static bool
skl_is_vblank_too_short(const struct intel_crtc_state *crtc_state,
int wm0_lines, int latency)
{
const struct drm_display_mode *adjusted_mode =
&crtc_state->hw.adjusted_mode;
- int linetime = DIV_ROUND_UP(1000 * adjusted_mode->htotal,
- adjusted_mode->clock);
return crtc_state->framestart_delay +
intel_usecs_to_scanlines(adjusted_mode, latency) +
- DIV_ROUND_UP(scaler_prefill_latency(crtc_state, linetime), linetime) +
- DIV_ROUND_UP(dsc_prefill_latency(crtc_state, linetime), linetime) +
wm0_lines >
adjusted_mode->crtc_vtotal - adjusted_mode->crtc_vblank_start;
}
--
2.45.2
next prev parent reply other threads:[~2025-09-07 7:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 7:32 [PATCH 00/14] Optimize vrr.guardband and fix LRR Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 01/14] drm/i915/vrr: Use crtc_vsync_start/end for computing vrr.vsync_start/end Ankit Nautiyal
2025-09-08 8:08 ` Shankar, Uma
2025-09-07 7:32 ` [PATCH 02/14] drm/i915/skl_watermark: Fix the scaling factor for chroma subsampling Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 03/14] drm/i915/skl_watermark: Pass linetime as argument to latency helpers Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 04/14] drm/i915/skl_scaler: Introduce helper for chroma downscale factor Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 05/14] drm/i915/display: Extract helpers to set dsc/scaler prefill latencies Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 06/14] drm/i915/dp: Add SDP latency computation helper Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 07/14] drm/i915/alpm: Add function to compute max link-wake latency Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 08/14] drm/i915/vrr: Use vrr.sync_start for getting vtotal Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 09/14] drm/i915/display: Add guardband check for feature latencies Ankit Nautiyal
2025-09-07 7:32 ` Ankit Nautiyal [this message]
2025-09-07 7:32 ` [PATCH 11/14] drm/i915/dsb: Align flipdone with delayed vblank using guardband wait Ankit Nautiyal
2025-09-08 8:05 ` Shankar, Uma
2025-09-07 7:32 ` [PATCH 12/14] drm/i915/vrr: Use static guardband to support seamless LRR switching Ankit Nautiyal
2025-09-08 16:43 ` Ville Syrjälä
2025-09-09 15:02 ` Nautiyal, Ankit K
2025-09-10 12:30 ` Ville Syrjälä
2025-09-10 13:37 ` Nautiyal, Ankit K
2025-09-07 7:32 ` [PATCH 13/14] drm/i915/panel: Refactor helper to get highest fixed mode Ankit Nautiyal
2025-09-07 7:32 ` [PATCH 14/14] drm/i915/vrr: Fix seamless_mn drrs for PTL Ankit Nautiyal
2025-09-08 20:33 ` ✓ CI.KUnit: success for Optimize vrr.guardband and fix LRR (rev9) Patchwork
2025-09-09 0:38 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-09 1:09 ` ✓ CI.KUnit: success for Optimize vrr.guardband and fix LRR (rev10) Patchwork
2025-09-09 1:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-09 8:02 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250907073241.19632-11-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=mitulkumar.ajitkumar.golani@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox