Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: daniele.ceraolospurio@intel.com, Zhanjun Dong <zhanjun.dong@intel.com>
Subject: [PATCH v1] drm/xe/uc: Change assertion to error on huc authentication failure
Date: Thu, 23 Oct 2025 14:13:32 -0400	[thread overview]
Message-ID: <20251023181332.2490921-1-zhanjun.dong@intel.com> (raw)

There is only 1 place that HuC authentication is critical, changed it to
error to avoid tanited kernel on assertion failed.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
 drivers/gpu/drm/xe/xe_uc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 465bda355443..2ae48dd234ee 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -220,7 +220,7 @@ int xe_uc_load_hw(struct xe_uc *uc)
 
 	/* We don't fail the driver load if HuC fails to auth, but let's warn */
 	ret = xe_huc_auth(&uc->huc, XE_HUC_AUTH_VIA_GUC);
-	xe_gt_assert(uc_to_gt(uc), !ret);
+	xe_gt_err(uc_to_gt(uc), "Huc authentication failed:%d\n", ret);
 
 	/* GSC load is async */
 	xe_gsc_load_start(&uc->gsc);
-- 
2.34.1


             reply	other threads:[~2025-10-23 18:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23 18:13 Zhanjun Dong [this message]
2025-10-23 18:17 ` [PATCH v1] drm/xe/uc: Change assertion to error on huc authentication failure Dixit, Ashutosh
2025-10-23 18:27 ` Daniele Ceraolo Spurio
2025-10-23 18:47   ` Dong, Zhanjun
2025-10-23 21:36 ` ✓ CI.KUnit: success for " Patchwork
2025-10-23 22:31 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-24 11:15 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023181332.2490921-1-zhanjun.dong@intel.com \
    --to=zhanjun.dong@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox