Re: [PATCH v1] drm/xe/uc: Change assertion to error on huc authentication failure

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 23 Oct 2025 11:13:32 -0700, Zhanjun Dong wrote:
>
> There is only 1 place that HuC authentication is critical, changed it to
> error to avoid tanited kernel on assertion failed.
>
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_uc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
> index 465bda355443..2ae48dd234ee 100644
> --- a/drivers/gpu/drm/xe/xe_uc.c
> +++ b/drivers/gpu/drm/xe/xe_uc.c
> @@ -220,7 +220,7 @@ int xe_uc_load_hw(struct xe_uc *uc)
>
>	/* We don't fail the driver load if HuC fails to auth, but let's warn */
>	ret = xe_huc_auth(&uc->huc, XE_HUC_AUTH_VIA_GUC);
> -	xe_gt_assert(uc_to_gt(uc), !ret);
> +	xe_gt_err(uc_to_gt(uc), "Huc authentication failed:%d\n", ret);

Hmm what about the comment just above?

>
>	/* GSC load is async */
>	xe_gsc_load_start(&uc->gsc);
> --
> 2.34.1
>