Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] drm/xe/uc: Change assertion to error on huc authentication failure
@ 2025-10-23 18:13 Zhanjun Dong
  2025-10-23 18:17 ` Dixit, Ashutosh
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Zhanjun Dong @ 2025-10-23 18:13 UTC (permalink / raw)
  To: intel-xe; +Cc: daniele.ceraolospurio, Zhanjun Dong

There is only 1 place that HuC authentication is critical, changed it to
error to avoid tanited kernel on assertion failed.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
 drivers/gpu/drm/xe/xe_uc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index 465bda355443..2ae48dd234ee 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -220,7 +220,7 @@ int xe_uc_load_hw(struct xe_uc *uc)
 
 	/* We don't fail the driver load if HuC fails to auth, but let's warn */
 	ret = xe_huc_auth(&uc->huc, XE_HUC_AUTH_VIA_GUC);
-	xe_gt_assert(uc_to_gt(uc), !ret);
+	xe_gt_err(uc_to_gt(uc), "Huc authentication failed:%d\n", ret);
 
 	/* GSC load is async */
 	xe_gsc_load_start(&uc->gsc);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-10-24 11:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-23 18:13 [PATCH v1] drm/xe/uc: Change assertion to error on huc authentication failure Zhanjun Dong
2025-10-23 18:17 ` Dixit, Ashutosh
2025-10-23 18:27 ` Daniele Ceraolo Spurio
2025-10-23 18:47   ` Dong, Zhanjun
2025-10-23 21:36 ` ✓ CI.KUnit: success for " Patchwork
2025-10-23 22:31 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-24 11:15 ` ✗ Xe.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox