From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
mitulkumar.ajitkumar.golani@intel.com,
ankit.k.nautiyal@intel.com, uma.shankar@intel.com,
ville.syrjala@linux.intel.com
Subject: [PATCH v8 16/22] drm/i915/display: Wait for VRR PUSH status update
Date: Mon, 27 Oct 2025 21:59:21 +0530 [thread overview]
Message-ID: <20251027162927.2655581-17-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20251027162927.2655581-1-mitulkumar.ajitkumar.golani@intel.com>
After VRR Push is sent, need to wait till flipline decision boundary
to get Push bit to get cleared.
Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 23 ++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 83a64b13dca3..ea4e1ec65db7 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7221,6 +7221,22 @@ static void intel_atomic_dsb_prepare(struct intel_atomic_state *state,
intel_color_prepare_commit(state, crtc);
}
+static int
+dcb_vmin_vblank_start(struct intel_crtc_state *crtc_state)
+{
+ return (intel_vrr_dcb_vmin_vblank_start_next(crtc_state) < 0) ?
+ intel_vrr_dcb_vmin_vblank_start_final(crtc_state) :
+ intel_vrr_dcb_vmin_vblank_start_next(crtc_state);
+}
+
+static int
+dcb_vmax_vblank_start(struct intel_crtc_state *crtc_state)
+{
+ return (intel_vrr_dcb_vmax_vblank_start_next(crtc_state) < 0) ?
+ intel_vrr_dcb_vmax_vblank_start_final(crtc_state) :
+ intel_vrr_dcb_vmax_vblank_start_next(crtc_state);
+}
+
static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
struct intel_crtc *crtc)
{
@@ -7305,6 +7321,13 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
intel_vrr_dcb_increment_flip_count(new_crtc_state, crtc);
intel_vrr_send_push(new_crtc_state->dsb_commit, new_crtc_state);
intel_dsb_wait_for_delayed_vblank(state, new_crtc_state->dsb_commit);
+
+ if (new_crtc_state->vrr.dc_balance.enable) {
+ intel_dsb_wait_scanline_in(state, new_crtc_state->dsb_commit,
+ dcb_vmin_vblank_start(new_crtc_state),
+ dcb_vmax_vblank_start(new_crtc_state));
+ }
+
intel_vrr_check_push_sent(new_crtc_state->dsb_commit,
new_crtc_state);
intel_dsb_interrupt(new_crtc_state->dsb_commit);
--
2.48.1
next prev parent reply other threads:[~2025-10-27 16:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 16:29 [PATCH v8 00/22] Enable/Disable DC balance along with VRR DSB Mitul Golani
2025-10-27 16:29 ` [PATCH v8 01/22] drm/i915/display: Add source param for dc balance Mitul Golani
2025-10-27 16:29 ` [PATCH v8 02/22] drm/i915/dmc: Add pipe dmc registers and bits for DC Balance Mitul Golani
2025-10-27 16:29 ` [PATCH v8 03/22] drm/i915/vrr: Add VRR DC balance registers Mitul Golani
2025-10-27 16:29 ` [PATCH v8 04/22] drm/i915/vrr: Add functions to read out vmin/vmax stuff Mitul Golani
2025-10-27 16:29 ` [PATCH v8 05/22] drm/i915/vrr: Add DC Balance params to crtc_state Mitul Golani
2025-10-27 16:29 ` [PATCH v8 06/22] drm/i915/vrr: Add state dump for DC Balance params Mitul Golani
2025-10-27 16:29 ` [PATCH v8 07/22] drm/i915/vrr: Add compute config " Mitul Golani
2025-10-27 16:29 ` [PATCH v8 08/22] drm/i915/display: Add DC Balance flip counter in crtc Mitul Golani
2025-10-27 16:29 ` [PATCH v8 09/22] drm/i915/vrr: Increment DC balance flip count on every flip Mitul Golani
2025-10-27 16:29 ` [PATCH v8 10/22] drm/i915/vrr: Add function to reset DC Balance flip count Mitul Golani
2025-10-27 16:29 ` [PATCH v8 11/22] drm/i915/vrr: Add function reset DC balance accumulated params Mitul Golani
2025-10-27 16:29 ` [PATCH v8 12/22] drm/i915/vrr: Write DC balance params to hw registers Mitul Golani
2025-10-27 16:29 ` [PATCH v8 13/22] drm/i915/vrr: Configure DC balance flipline adjustment Mitul Golani
2025-10-27 16:29 ` [PATCH v8 14/22] drm/i915/vblank: Extract vrr_vblank_start() Mitul Golani
2025-10-27 16:29 ` [PATCH v8 15/22] drm/i915/vrr: Implement vblank evasion with DC balancing Mitul Golani
2025-10-27 16:29 ` Mitul Golani [this message]
2025-10-27 16:29 ` [PATCH v8 17/22] drm/i915/dsb: Add pipedmc dc balance enable/disable Mitul Golani
2025-10-27 16:29 ` [PATCH v8 18/22] drm/i915/vrr: Pause DC Balancing for DSB commits Mitul Golani
2025-10-27 16:29 ` [PATCH v8 19/22] drm/i915/display: Add function to configure event for dc balance Mitul Golani
2025-10-27 16:29 ` [PATCH v8 20/22] drm/i915/vrr: Enable Adaptive sync counter bit Mitul Golani
2025-10-27 16:29 ` [PATCH v8 21/22] drm/i915/vrr: Enable DC Balance Mitul Golani
2025-10-27 16:29 ` [PATCH v8 22/22] drm/i915/vrr: Add function to check if DC Balance Possible Mitul Golani
2025-10-27 19:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027162927.2655581-17-mitulkumar.ajitkumar.golani@intel.com \
--to=mitulkumar.ajitkumar.golani@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox