Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Subject: [FOR-CI 01/10] drm/i915/display: Make get_vblank_counter use intel_de_read_fw()
Date: Fri,  7 Nov 2025 20:39:36 +0100	[thread overview]
Message-ID: <20251107193946.1075137-2-dev@lankhorst.se> (raw)
In-Reply-To: <20251107193946.1075137-1-dev@lankhorst.se>

Fixes the following lockdep splat on PREEMPT_RT:
<3> BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
<3> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 1373, name: xe_module_load
<3> preempt_count: 1, expected: 0
<3> RCU nest depth: 0, expected: 0
<4> 11 locks held by xe_module_load/1373:
<4>  #0: ffff888107b691a0 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x104/0x220
<4>  #1: ffff88813cd30280 (&dev->clientlist_mutex){+.+.}-{3:3}, at: drm_client_register+0x32/0xe0
<4>  #2: ffffffff837f88f8 (registration_lock){+.+.}-{3:3}, at: register_framebuffer+0x1b/0x50
<4>  #3: ffffffff835985e0 (console_lock){+.+.}-{0:0}, at: fbcon_fb_registered+0x6f/0x90
<4>  #4: ffff88812589e6a0 (&helper->lock){+.+.}-{3:3}, at: __drm_fb_helper_restore_fbdev_mode_unlocked+0x7b/0x110
<4>  #5: ffff88813cd30158 (&dev->master_mutex){+.+.}-{3:3}, at: drm_master_internal_acquire+0x20/0x50
<4>  #6: ffff88812589e488 (&client->modeset_mutex){+.+.}-{3:3}, at: drm_client_modeset_commit_locked+0x2a/0x1b0
<4>  #7: ffffc9000031eef0 (crtc_ww_class_acquire){+.+.}-{0:0}, at: drm_client_modeset_commit_atomic+0x4c/0x2b0
<4>  #8: ffffc9000031ef18 (crtc_ww_class_mutex){+.+.}-{3:3}, at: drm_client_modeset_commit_atomic+0x4c/0x2b0
<4>  #9: ffff888114f7b8b8 (&intel_dp->psr.lock){+.+.}-{3:3}, at: intel_psr_lock+0xc5/0xf0 [xe]
<4>  #10: ffff88812a0cbbc0 (&wl->lock){+.+.}-{2:2}, at: intel_dmc_wl_get+0x3c/0x140 [xe]

This splat will happen otherwise on all tracepoints too, for similar reasons.

Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/i915/display/intel_vblank.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index 671f357c65638..2b106ffa3f5f5 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -133,7 +133,7 @@ u32 g4x_get_vblank_counter(struct drm_crtc *crtc)
 	if (!vblank->max_vblank_count)
 		return 0;
 
-	return intel_de_read(display, PIPE_FRMCOUNT_G4X(display, pipe));
+	return intel_de_read_fw(display, PIPE_FRMCOUNT_G4X(display, pipe));
 }
 
 static u32 intel_crtc_scanlines_since_frame_timestamp(struct intel_crtc *crtc)
-- 
2.51.0


  reply	other threads:[~2025-11-07 19:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 19:39 [FOR-CI 00/10] Fixed PREEMPT_RT CI run Maarten Lankhorst
2025-11-07 19:39 ` Maarten Lankhorst [this message]
2025-11-07 20:43   ` [FOR-CI 01/10] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Matt Roper
2025-11-08  7:40     ` Maarten Lankhorst
2025-11-10 16:52       ` Matt Roper
2025-11-07 19:39 ` [FOR-CI 02/10] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 03/10] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 04/10] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 05/10] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 06/10] drm/i915/display: Enable interrupts earlier on PREEMPT_RT Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 07/10] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 08/10] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 09/10] drm/i915/display: Remove dirty_rect from fbc state Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 10/10] PREEMPT_RT injection Maarten Lankhorst
2025-11-07 23:51 ` ✗ CI.checkpatch: warning for Fixed PREEMPT_RT CI run Patchwork
2025-11-07 23:52 ` ✓ CI.KUnit: success " Patchwork
2025-11-08  0:10 ` ✗ CI.checksparse: warning " Patchwork
2025-11-08  0:50 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-11-09  6:57 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251107193946.1075137-2-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox