From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Subject: [FOR-CI 05/10] drm/i915/display: Make icl_dsi_frame_update use _fw too
Date: Fri, 7 Nov 2025 20:39:40 +0100 [thread overview]
Message-ID: <20251107193946.1075137-6-dev@lankhorst.se> (raw)
In-Reply-To: <20251107193946.1075137-1-dev@lankhorst.se>
Don't use the dmc lock inside the vblank critical section,
not even as last call.
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/gpu/drm/i915/display/icl_dsi.c | 4 ++--
drivers/gpu/drm/i915/display/intel_de.h | 6 ++++++
| 2 ++
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index 70d4c1bc70fc3..e52b434ac8f11 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -243,8 +243,8 @@ void icl_dsi_frame_update(struct intel_crtc_state *crtc_state)
else
return;
- intel_de_rmw(display, DSI_CMD_FRMCTL(port), 0,
- DSI_FRAME_UPDATE_REQUEST);
+ intel_de_rmw_fw(display, DSI_CMD_FRMCTL(port), 0,
+ DSI_FRAME_UPDATE_REQUEST);
}
static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)
diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h
index 9ecdcf6b73e4d..15f606a4a2e9d 100644
--- a/drivers/gpu/drm/i915/display/intel_de.h
+++ b/drivers/gpu/drm/i915/display/intel_de.h
@@ -214,6 +214,12 @@ intel_de_write_fw(struct intel_display *display, i915_reg_t reg, u32 val)
intel_uncore_write_fw(__to_uncore(display), reg, val);
}
+static inline void
+intel_de_rmw_fw(struct intel_display *display, i915_reg_t reg, u32 clear, u32 set)
+{
+ intel_uncore_rmw_fw(__to_uncore(display), reg, clear, set);
+}
+
static inline u32
intel_de_read_notrace(struct intel_display *display, i915_reg_t reg)
{
--git a/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h b/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h
index d012f02bc84f7..57d5ffabf2d52 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/intel_uncore.h
@@ -91,6 +91,8 @@ static inline u32 intel_uncore_rmw(struct intel_uncore *uncore,
return xe_mmio_rmw32(__compat_uncore_to_mmio(uncore), reg, clear, set);
}
+#define intel_uncore_rmw_fw intel_uncore_rmw
+
static inline int intel_wait_for_register(struct intel_uncore *uncore,
i915_reg_t i915_reg, u32 mask,
u32 value, unsigned int timeout)
--
2.51.0
next prev parent reply other threads:[~2025-11-07 19:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 19:39 [FOR-CI 00/10] Fixed PREEMPT_RT CI run Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 01/10] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Maarten Lankhorst
2025-11-07 20:43 ` Matt Roper
2025-11-08 7:40 ` Maarten Lankhorst
2025-11-10 16:52 ` Matt Roper
2025-11-07 19:39 ` [FOR-CI 02/10] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 03/10] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 04/10] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2025-11-07 19:39 ` Maarten Lankhorst [this message]
2025-11-07 19:39 ` [FOR-CI 06/10] drm/i915/display: Enable interrupts earlier on PREEMPT_RT Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 07/10] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 08/10] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 09/10] drm/i915/display: Remove dirty_rect from fbc state Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 10/10] PREEMPT_RT injection Maarten Lankhorst
2025-11-07 23:51 ` ✗ CI.checkpatch: warning for Fixed PREEMPT_RT CI run Patchwork
2025-11-07 23:52 ` ✓ CI.KUnit: success " Patchwork
2025-11-08 0:10 ` ✗ CI.checksparse: warning " Patchwork
2025-11-08 0:50 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-11-09 6:57 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107193946.1075137-6-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox