Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Subject: [FOR-CI 06/10] drm/i915/display: Enable interrupts earlier on PREEMPT_RT
Date: Fri,  7 Nov 2025 20:39:41 +0100	[thread overview]
Message-ID: <20251107193946.1075137-7-dev@lankhorst.se> (raw)
In-Reply-To: <20251107193946.1075137-1-dev@lankhorst.se>

The last part of the vblank evasion is about updating bookkeeping,
not programming hardware registers.

The interrupts cannot stay disabled here on PREEMPT_RT since the
spinlocks get converted to mutexes.

Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/i915/display/intel_crtc.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 9d2a23c96c61b..b87f6b4a4f3d7 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -688,6 +688,14 @@ void intel_pipe_update_end(struct intel_atomic_state *state,
 	    intel_crtc_has_type(new_crtc_state, INTEL_OUTPUT_DSI))
 		icl_dsi_frame_update(new_crtc_state);
 
+#if IS_ENABLED(CONFIG_PREEMPT_RT)
+	/*
+	 * Timing sensitive register writing completed, non-deterministic
+	 * locking from here on out.
+	 */
+	local_irq_enable();
+#endif
+
 	/* We're still in the vblank-evade critical section, this can't race.
 	 * Would be slightly nice to just grab the vblank count and arm the
 	 * event outside of the critical section - the spinlock might spin for a
@@ -735,7 +743,9 @@ void intel_pipe_update_end(struct intel_atomic_state *state,
 	if (!state->base.legacy_cursor_update)
 		intel_vrr_send_push(NULL, new_crtc_state);
 
+#if !IS_ENABLED(CONFIG_PREEMPT_RT)
 	local_irq_enable();
+#endif
 
 	if (intel_vgpu_active(dev_priv))
 		goto out;
-- 
2.51.0


  parent reply	other threads:[~2025-11-07 19:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 19:39 [FOR-CI 00/10] Fixed PREEMPT_RT CI run Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 01/10] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Maarten Lankhorst
2025-11-07 20:43   ` Matt Roper
2025-11-08  7:40     ` Maarten Lankhorst
2025-11-10 16:52       ` Matt Roper
2025-11-07 19:39 ` [FOR-CI 02/10] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 03/10] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 04/10] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 05/10] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2025-11-07 19:39 ` Maarten Lankhorst [this message]
2025-11-07 19:39 ` [FOR-CI 07/10] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 08/10] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 09/10] drm/i915/display: Remove dirty_rect from fbc state Maarten Lankhorst
2025-11-07 19:39 ` [FOR-CI 10/10] PREEMPT_RT injection Maarten Lankhorst
2025-11-07 23:51 ` ✗ CI.checkpatch: warning for Fixed PREEMPT_RT CI run Patchwork
2025-11-07 23:52 ` ✓ CI.KUnit: success " Patchwork
2025-11-08  0:10 ` ✗ CI.checksparse: warning " Patchwork
2025-11-08  0:50 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-11-09  6:57 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251107193946.1075137-7-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox