Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nemesa Garg <nemesa.garg@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@intel.com, uma.shankar@intel.com,
	Nemesa Garg <nemesa.garg@intel.com>
Subject: [PATCH 3/5] drm/i915/display: Pass dsb_commit to CASF helpers
Date: Tue,  9 Dec 2025 11:55:25 +0530	[thread overview]
Message-ID: <20251209062527.620382-4-nemesa.garg@intel.com> (raw)
In-Reply-To: <20251209062527.620382-1-nemesa.garg@intel.com>

Incase of non-modeset enable the casf, update the
strength or disable the casf through dsb.

Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 256103d55409..7edfc8c2ae21 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7300,6 +7300,8 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
 	struct intel_display *display = to_intel_display(state);
 	struct intel_crtc_state *new_crtc_state =
 		intel_atomic_get_new_crtc_state(state, crtc);
+	struct intel_crtc_state *old_crtc_state =
+		intel_atomic_get_old_crtc_state(state, crtc);
 	unsigned int size = new_crtc_state->plane_color_changed ? 8192 : 1024;
 
 	if (!new_crtc_state->use_flipq &&
@@ -7332,6 +7334,16 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,
 		if (intel_crtc_needs_color_update(new_crtc_state))
 			intel_color_commit_noarm(new_crtc_state->dsb_commit,
 						 new_crtc_state);
+		if (intel_casf_enabling(new_crtc_state, old_crtc_state))
+			intel_casf_enable(new_crtc_state->dsb_commit,
+					  new_crtc_state);
+		else if (new_crtc_state->hw.casf_params.strength !=
+				old_crtc_state->hw.casf_params.strength)
+			intel_casf_update_strength(new_crtc_state->dsb_commit,
+						   new_crtc_state);
+		if (intel_casf_disabling(old_crtc_state, new_crtc_state))
+			intel_casf_disable(new_crtc_state->dsb_commit,
+					   new_crtc_state);
 		intel_crtc_planes_update_noarm(new_crtc_state->dsb_commit,
 					       state, crtc);
 
-- 
2.25.1


  parent reply	other threads:[~2025-12-09  6:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09  6:25 [PATCH 0/5] Make casf updates atomic and dsb ready Nemesa Garg
2025-12-09  6:25 ` [PATCH 1/5] drm/i915/display: Move casf_compute_config Nemesa Garg
2025-12-12 15:51   ` Ville Syrjälä
2025-12-09  6:25 ` [PATCH 2/5] drm/i915/display: Add intel_dsb param to CASF helpers Nemesa Garg
2025-12-09  6:25 ` Nemesa Garg [this message]
2025-12-12 16:34   ` [PATCH 3/5] drm/i915/display: Pass dsb_commit " Ville Syrjälä
2025-12-16 14:59     ` Garg, Nemesa
2025-12-17  3:10       ` Garg, Nemesa
2025-12-09  6:25 ` [PATCH 4/5] drm/i915/display: Add intel_casf_arm() to enable casf Nemesa Garg
2025-12-09  6:25 ` [PATCH 5/5] drm/i915/display: Introduce skl_pipe_scaler_setup() Nemesa Garg
2025-12-09  6:36 ` ✓ CI.KUnit: success for Make casf updates atomic and dsb ready Patchwork
2025-12-09  7:10 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-09 13:31 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251209062527.620382-4-nemesa.garg@intel.com \
    --to=nemesa.garg@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox