Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 5/5] drm/xe: improve header check
Date: Wed,  7 Jan 2026 17:54:01 +0200	[thread overview]
Message-ID: <20260107155401.2379127-5-jani.nikula@intel.com> (raw)
In-Reply-To: <20260107155401.2379127-1-jani.nikula@intel.com>

Improve header check: Remove unused -DHDRTEST. Include the header twice
to check for include guards. Run kernel-doc on the header.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/xe/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 2b20c79d7ec9..b39cbb756232 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -370,7 +370,8 @@ always-$(CONFIG_DRM_XE_WERROR) += \
 	$(patsubst %.h,%.hdrtest, $(shell cd $(src) && find * -name '*.h' $(hdrtest_find_args)))
 
 quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
-      cmd_hdrtest = $(CC) -DHDRTEST $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
+      cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $< -include $<; \
+		$(srctree)/scripts/kernel-doc -none -Werror $<; touch $@
 
 $(obj)/%.hdrtest: $(src)/%.h FORCE
 	$(call if_changed_dep,hdrtest)
-- 
2.47.3


  parent reply	other threads:[~2026-01-07 15:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 15:53 [PATCH 1/5] drm/xe/guc: fix struct guc_lfd_file_header kernel-doc Jani Nikula
2026-01-07 15:53 ` [PATCH 2/5] drm/xe/vf: fix struct xe_gt_sriov_vf_migration kernel-doc Jani Nikula
2026-01-07 17:45   ` Matt Roper
2026-01-07 15:53 ` [PATCH 3/5] drm/xe/xe_late_bind_fw: fix enum xe_late_bind_fw_id kernel-doc Jani Nikula
2026-01-07 17:39   ` Nilawar, Badal
2026-01-07 15:54 ` [PATCH 4/5] drm/xe/vm: fix xe_vm_validation_exec() kernel-doc Jani Nikula
2026-01-07 17:49   ` Matt Roper
2026-01-07 15:54 ` Jani Nikula [this message]
2026-01-07 18:00   ` [PATCH 5/5] drm/xe: improve header check Matt Roper
2026-01-09  9:12     ` Jani Nikula
2026-01-09 15:41       ` Jani Nikula
2026-01-07 16:01 ` ✓ CI.KUnit: success for series starting with [1/5] drm/xe/guc: fix struct guc_lfd_file_header kernel-doc Patchwork
2026-01-07 16:43 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-07 17:44 ` [PATCH 1/5] " Matt Roper
2026-01-07 17:59 ` Dong, Zhanjun
2026-01-07 18:29 ` ✗ Xe.CI.Full: failure for series starting with [1/5] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260107155401.2379127-5-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox