Re: [PATCH 5/5] drm/xe: improve header check

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 09 Jan 2026, Jani Nikula <jani.nikula@intel.com> wrote:
> On Wed, 07 Jan 2026, Matt Roper <matthew.d.roper@intel.com> wrote:
>> On Wed, Jan 07, 2026 at 05:54:01PM +0200, Jani Nikula wrote:
>>> Improve header check: Remove unused -DHDRTEST. Include the header twice
>>> to check for include guards. Run kernel-doc on the header.
>>> 
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>>
>> Didn't we used to have kerneldoc checks running in a CI.Hooks task on
>> pre-merge?  It seems like those vanished at some point and these
>> mistakes started creeping in...
>
> I think they were running the full Sphinx build, which only checks
> kernel-doc comments that are actually incorporated in the documentation
> build. Everything else was ignored. But then there were a lot of
> failures in the hook too [1]. I don't know what happened.

Anyway, thanks for the reviews, merged to drm-xe-next.

>
> BR,
> Jani.
>
>
> [1] https://lore.kernel.org/r/175854145966.353633.13388139741450056729@1538d3639d33
>
>>
>>
>> Matt
>>
>>> ---
>>>  drivers/gpu/drm/xe/Makefile | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
>>> index 2b20c79d7ec9..b39cbb756232 100644
>>> --- a/drivers/gpu/drm/xe/Makefile
>>> +++ b/drivers/gpu/drm/xe/Makefile
>>> @@ -370,7 +370,8 @@ always-$(CONFIG_DRM_XE_WERROR) += \
>>>  	$(patsubst %.h,%.hdrtest, $(shell cd $(src) && find * -name '*.h' $(hdrtest_find_args)))
>>>  
>>>  quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@)
>>> -      cmd_hdrtest = $(CC) -DHDRTEST $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@
>>> +      cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $< -include $<; \
>>> +		$(srctree)/scripts/kernel-doc -none -Werror $<; touch $@
>>>  
>>>  $(obj)/%.hdrtest: $(src)/%.h FORCE
>>>  	$(call if_changed_dep,hdrtest)
>>> -- 
>>> 2.47.3
>>> 

-- 
Jani Nikula, Intel