Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dibin.moolakadan.subrahmanian@intel.com, jani.nikula@intel.com,
	Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v2 09/10] drm/i915/cmtg: enable cmtg in secondary mode
Date: Tue,  3 Feb 2026 19:14:06 +0530	[thread overview]
Message-ID: <20260203134407.2823406-10-animesh.manna@intel.com> (raw)
In-Reply-To: <20260203134407.2823406-1-animesh.manna@intel.com>

From: Dibin Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@intel.com>

Wait for CMTG_SYNC_TO_PORT bit clear in cmtg enable sequence
and then enable secondary mode for cmtg.

Signed-off-by: Dibin Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_cmtg.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cmtg.c b/drivers/gpu/drm/i915/display/intel_cmtg.c
index f7364c7408d5..d1ec9b79cef2 100644
--- a/drivers/gpu/drm/i915/display/intel_cmtg.c
+++ b/drivers/gpu/drm/i915/display/intel_cmtg.c
@@ -277,4 +277,18 @@ void intel_cmtg_enable(const struct intel_crtc_state *crtc_state)
 
 	/* Program Enable Cmtg */
 	intel_cmtg_ctl_enable(crtc_state);
+
+	if (intel_de_wait_for_clear_ms(display, TRANS_CMTG_CTL(cpu_transcoder),
+				       CMTG_SYNC_TO_PORT, 50)) {
+		drm_WARN(display->drm, 1, "CMTG:%d enable timeout\n", cpu_transcoder);
+		return;
+	}
+
+	/*
+	 *  eDP transcoder registers as secondary to CMTG by setting
+	 *  TRANS_DDI_FUNC_CTL2[CMTG Secondary Mode].
+	 */
+	intel_de_rmw(display, TRANS_DDI_FUNC_CTL2(display, cpu_transcoder), 0, CMTG_SECONDARY_MODE);
+
+	drm_dbg_kms(display->drm, "CMTG:%d enabled\n", cpu_transcoder);
 }
-- 
2.29.0


  parent reply	other threads:[~2026-02-03 14:13 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 13:43 [PATCH v2 00/10] CMTG enablement Animesh Manna
2026-02-03 13:43 ` [PATCH v2 01/10] drm/i915/cmtg: enable cmtg LNL onwards Animesh Manna
2026-02-05  5:18   ` Kandpal, Suraj
2026-02-05  8:43     ` Jani Nikula
2026-02-03 13:43 ` [PATCH v2 02/10] drm/i915/cmtg: cmtg set clock select Animesh Manna
2026-02-05  5:25   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 03/10] drm/i915/cmtg: set timings for cmtg Animesh Manna
2026-02-05  5:35   ` Kandpal, Suraj
2026-02-05  8:47   ` Jani Nikula
2026-02-06  5:50     ` Manna, Animesh
2026-02-03 13:44 ` [PATCH v2 04/10] drm/i915/cmtg: program vrr registers of cmtg Animesh Manna
2026-02-06  2:54   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 05/10] drm/i915/cmtg: program set context latency " Animesh Manna
2026-02-06  3:08   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 06/10] drm/i915/cmtg: set transcoder mn for cmtg Animesh Manna
2026-02-06  3:22   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 07/10] drm/i915/cmtg: program sync to port " Animesh Manna
2026-02-06  3:28   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 08/10] drm/i915/cmtg: enable cmtg ctl Animesh Manna
2026-02-05  8:50   ` Jani Nikula
2026-02-06  5:52     ` Manna, Animesh
2026-02-03 13:44 ` Animesh Manna [this message]
2026-02-05  8:53   ` [PATCH v2 09/10] drm/i915/cmtg: enable cmtg in secondary mode Jani Nikula
2026-02-06  5:56     ` Manna, Animesh
2026-02-03 13:44 ` [PATCH v2 10/10] drm/i915/cmtg: disable CMTG on transcoder disable Animesh Manna
2026-02-06  3:31   ` Kandpal, Suraj
2026-02-03 14:53 ` ✓ CI.KUnit: success for CMTG enablement (rev2) Patchwork
2026-02-03 15:08 ` ✗ CI.checksparse: warning " Patchwork
2026-02-03 15:28 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-04  5:45 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-04 17:52 ` ✓ CI.KUnit: success for CMTG enablement (rev3) Patchwork
2026-02-04 18:08 ` ✗ CI.checksparse: warning " Patchwork
2026-02-04 19:03 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-04 20:33 ` Patchwork
2026-02-05  5:33 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203134407.2823406-10-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=dibin.moolakadan.subrahmanian@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox