Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dibin.moolakadan.subrahmanian@intel.com, jani.nikula@intel.com,
	Animesh Manna <animesh.manna@intel.com>
Subject: [PATCH v2 04/10] drm/i915/cmtg: program vrr registers of cmtg
Date: Tue,  3 Feb 2026 19:14:01 +0530	[thread overview]
Message-ID: <20260203134407.2823406-5-animesh.manna@intel.com> (raw)
In-Reply-To: <20260203134407.2823406-1-animesh.manna@intel.com>

Enable vrr if it is enabled on cmtg registers.

v2: Use sw state instead of reading from hardware. [Jani]

Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_cmtg.c          | 12 ++++++++++++
 drivers/gpu/drm/i915/display/intel_cmtg_regs.h     |  5 +++++
 drivers/gpu/drm/i915/display/intel_display_types.h |  1 +
 drivers/gpu/drm/i915/display/intel_vrr.c           |  4 ++++
 4 files changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cmtg.c b/drivers/gpu/drm/i915/display/intel_cmtg.c
index 4220eeece07f..26adf70cdd00 100644
--- a/drivers/gpu/drm/i915/display/intel_cmtg.c
+++ b/drivers/gpu/drm/i915/display/intel_cmtg.c
@@ -17,6 +17,7 @@
 #include "intel_display_power.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_vrr.h"
 
 /**
  * DOC: Common Primary Timing Generator (CMTG)
@@ -220,6 +221,17 @@ static void intel_cmtg_set_timings(const struct intel_crtc_state *crtc_state)
 	intel_de_write(display, TRANS_VTOTAL_CMTG(cpu_transcoder), crtc->cmtg.vtotal);
 	intel_de_write(display, TRANS_VBLANK_CMTG(cpu_transcoder), crtc->cmtg.vblank);
 	intel_de_write(display, TRANS_VSYNC_CMTG(cpu_transcoder), crtc->cmtg.vsync);
+
+	if (intel_vrr_possible(crtc_state) && intel_vrr_always_use_vrr_tg(display)) {
+		intel_de_write(display, TRANS_VRR_VMIN_CMTG(cpu_transcoder),
+			       crtc_state->vrr.vmin - 1);
+		intel_de_write(display, TRANS_VRR_VMAX_CMTG(cpu_transcoder),
+			       crtc_state->vrr.vmax - 1);
+		intel_de_write(display, TRANS_VRR_FLIPLINE_CMTG(cpu_transcoder),
+			       crtc_state->vrr.flipline - 1);
+		intel_de_write(display, TRANS_VRR_CTL_CMTG(cpu_transcoder),
+			       crtc->cmtg.vrr_ctl);
+	}
 }
 
 void intel_cmtg_enable(const struct intel_crtc_state *crtc_state)
diff --git a/drivers/gpu/drm/i915/display/intel_cmtg_regs.h b/drivers/gpu/drm/i915/display/intel_cmtg_regs.h
index eb24827d22f5..eab90415d0da 100644
--- a/drivers/gpu/drm/i915/display/intel_cmtg_regs.h
+++ b/drivers/gpu/drm/i915/display/intel_cmtg_regs.h
@@ -27,4 +27,9 @@
 #define TRANS_VBLANK_CMTG(id)		_MMIO(0x6F010 + (id) * 0x100)
 #define TRANS_VSYNC_CMTG(id)		_MMIO(0x6F014 + (id) * 0x100)
 
+#define TRANS_VRR_CTL_CMTG(id)		_MMIO(0x6F420 + (id) * 0x100)
+#define TRANS_VRR_VMAX_CMTG(id)		_MMIO(0x6F424 + (id) * 0x100)
+#define TRANS_VRR_VMIN_CMTG(id)		_MMIO(0x6F434 + (id) * 0x100)
+#define TRANS_VRR_FLIPLINE_CMTG(id)	_MMIO(0x6F438 + (id) * 0x100)
+
 #endif /* __INTEL_CMTG_REGS_H__ */
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index defb54dd0bbe..a87f3ec10aea 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1574,6 +1574,7 @@ struct intel_crtc {
 		bool enable;
 		u32 htotal, hblank, hsync;
 		u32 vtotal, vblank, vsync;
+		u32 vrr_ctl;
 	} cmtg;
 };
 
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 9d814cc2d608..2c1ae685400f 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -892,6 +892,7 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state,
 {
 	struct intel_display *display = to_intel_display(crtc_state);
 	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
+	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
 	u32 vrr_ctl;
 
 	intel_de_write(display, TRANS_PUSH(display, cpu_transcoder),
@@ -907,6 +908,9 @@ static void intel_vrr_tg_enable(const struct intel_crtc_state *crtc_state,
 	if (cmrr_enable)
 		vrr_ctl |= VRR_CTL_CMRR_ENABLE;
 
+	if (crtc->cmtg.enable)
+		crtc->cmtg.vrr_ctl = vrr_ctl;
+
 	intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder), vrr_ctl);
 }
 
-- 
2.29.0


  parent reply	other threads:[~2026-02-03 14:13 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 13:43 [PATCH v2 00/10] CMTG enablement Animesh Manna
2026-02-03 13:43 ` [PATCH v2 01/10] drm/i915/cmtg: enable cmtg LNL onwards Animesh Manna
2026-02-05  5:18   ` Kandpal, Suraj
2026-02-05  8:43     ` Jani Nikula
2026-02-03 13:43 ` [PATCH v2 02/10] drm/i915/cmtg: cmtg set clock select Animesh Manna
2026-02-05  5:25   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 03/10] drm/i915/cmtg: set timings for cmtg Animesh Manna
2026-02-05  5:35   ` Kandpal, Suraj
2026-02-05  8:47   ` Jani Nikula
2026-02-06  5:50     ` Manna, Animesh
2026-02-03 13:44 ` Animesh Manna [this message]
2026-02-06  2:54   ` [PATCH v2 04/10] drm/i915/cmtg: program vrr registers of cmtg Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 05/10] drm/i915/cmtg: program set context latency " Animesh Manna
2026-02-06  3:08   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 06/10] drm/i915/cmtg: set transcoder mn for cmtg Animesh Manna
2026-02-06  3:22   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 07/10] drm/i915/cmtg: program sync to port " Animesh Manna
2026-02-06  3:28   ` Kandpal, Suraj
2026-02-03 13:44 ` [PATCH v2 08/10] drm/i915/cmtg: enable cmtg ctl Animesh Manna
2026-02-05  8:50   ` Jani Nikula
2026-02-06  5:52     ` Manna, Animesh
2026-02-03 13:44 ` [PATCH v2 09/10] drm/i915/cmtg: enable cmtg in secondary mode Animesh Manna
2026-02-05  8:53   ` Jani Nikula
2026-02-06  5:56     ` Manna, Animesh
2026-02-03 13:44 ` [PATCH v2 10/10] drm/i915/cmtg: disable CMTG on transcoder disable Animesh Manna
2026-02-06  3:31   ` Kandpal, Suraj
2026-02-03 14:53 ` ✓ CI.KUnit: success for CMTG enablement (rev2) Patchwork
2026-02-03 15:08 ` ✗ CI.checksparse: warning " Patchwork
2026-02-03 15:28 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-04  5:45 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-04 17:52 ` ✓ CI.KUnit: success for CMTG enablement (rev3) Patchwork
2026-02-04 18:08 ` ✗ CI.checksparse: warning " Patchwork
2026-02-04 19:03 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-04 20:33 ` Patchwork
2026-02-05  5:33 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203134407.2823406-5-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=dibin.moolakadan.subrahmanian@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox