From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Matt Roper <matthew.d.roper@intel.com>,
Shuicheng Lin <shuicheng.lin@intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH v2 00/10] Engine initialization cleanup
Date: Fri, 24 Apr 2026 13:48:10 -0700 [thread overview]
Message-ID: <20260424-engine-setup-v2-0-59cc620a25f1@intel.com> (raw)
A lot of our engine initialization code was inherited from i915 and
hasn't received too much cleanup since that time. There's also some
inconsistencies between the main initialization path used on all
platforms, and the vestigial execlist code which isn't actually used but
still remains in the driver as dead code for now. Let's clean things up
a bit and, where possible, move the required engine programming into the
RTP infrastructure so that it will be applied on both initialization
paths, and be dumpable/checkable via debugfs.
There's some more restructuring that should happen to more clearly
distinguish software state initialization from hardware initialization
(and re-initialization on various resets & suspend/resume), but I'll
leave that to a follow-up series to prevent this one from getting too
complicated.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
Changes in v2:
- Restrict CCS enablement to Xe_HP and later. The CCS engine has never
been enabled on Xe_LP.
- Fix rules on MSI-X enablement to actually use the
xe_rtp_match_has_msix function added. (Shuicheng)
- Drop xe_hw_engine_mmio_write32() prototype from header. (Shuicheng)
- Link to v1: https://lore.kernel.org/r/20260423-engine-setup-v1-0-baa94014e3e5@intel.com
---
Matt Roper (10):
drm/xe: Move CCS enablement to engine setup RTP
drm/xe/rtp: Add "always true" match function
drm/xe: Stop programming BLIT_CCTL on Xe2 and later platforms
drm/xe: Move HWSTAM programming to RTP
drm/xe: Fix name and definition of GFX_MODE register
drm/xe: Const-ify parameters to xe_device_has_* functions
drm/xe: Move GFX_MODE programming to RTP
drm/xe: Drop unnecessary STOP_RING clearing
drm/xe: Drop xe_hw_engine_mmio_write32()
drm/xe: Mark BCS engines as belonging to the GT forcewake domain
drivers/gpu/drm/xe/regs/xe_engine_regs.h | 5 +-
drivers/gpu/drm/xe/xe_device.h | 14 +++---
drivers/gpu/drm/xe/xe_execlist.c | 9 ----
drivers/gpu/drm/xe/xe_guc_ads.c | 2 -
drivers/gpu/drm/xe/xe_guc_capture.c | 2 +-
drivers/gpu/drm/xe/xe_hw_engine.c | 83 +++++++++++++-------------------
drivers/gpu/drm/xe/xe_hw_engine.h | 1 -
drivers/gpu/drm/xe/xe_lrc.c | 20 --------
drivers/gpu/drm/xe/xe_rtp.c | 15 ++++++
drivers/gpu/drm/xe/xe_rtp.h | 24 +++++++++
10 files changed, 82 insertions(+), 93 deletions(-)
---
base-commit: 6784fa94a98ae6fceef9c2c171c3e9fb8be6585f
change-id: 20260402-engine-setup-e66851295e18
Best regards,
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
next reply other threads:[~2026-04-24 20:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 20:48 Matt Roper [this message]
2026-04-24 20:48 ` [PATCH v2 01/10] drm/xe: Move CCS enablement to engine setup RTP Matt Roper
2026-04-24 20:48 ` [PATCH v2 02/10] drm/xe/rtp: Add "always true" match function Matt Roper
2026-04-24 20:48 ` [PATCH v2 03/10] drm/xe: Stop programming BLIT_CCTL on Xe2 and later platforms Matt Roper
2026-04-24 20:48 ` [PATCH v2 04/10] drm/xe: Move HWSTAM programming to RTP Matt Roper
2026-04-24 20:48 ` [PATCH v2 05/10] drm/xe: Fix name and definition of GFX_MODE register Matt Roper
2026-04-24 20:48 ` [PATCH v2 06/10] drm/xe: Const-ify parameters to xe_device_has_* functions Matt Roper
2026-04-24 20:48 ` [PATCH v2 07/10] drm/xe: Move GFX_MODE programming to RTP Matt Roper
2026-04-24 20:48 ` [PATCH v2 08/10] drm/xe: Drop unnecessary STOP_RING clearing Matt Roper
2026-04-24 20:48 ` [PATCH v2 09/10] drm/xe: Drop xe_hw_engine_mmio_write32() Matt Roper
2026-04-24 20:48 ` [PATCH v2 10/10] drm/xe: Mark BCS engines as belonging to the GT forcewake domain Matt Roper
2026-04-24 21:27 ` ✓ CI.KUnit: success for Engine initialization cleanup (rev2) Patchwork
2026-04-24 22:30 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-24 23:15 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424-engine-setup-v2-0-59cc620a25f1@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=shuicheng.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox