Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH 6/7] drm/xe/display: Drop xe_display_driver_set_hooks()
Date: Tue, 12 May 2026 20:33:41 +0200	[thread overview]
Message-ID: <20260512183342.3374-7-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20260512183342.3374-1-michal.wajdeczko@intel.com>

This function is now no-op.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/xe/display/xe_display.c | 16 ----------------
 drivers/gpu/drm/xe/display/xe_display.h |  3 +--
 drivers/gpu/drm/xe/xe_device.c          |  2 --
 3 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 7e5382fc161d..d6aea18025af 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -70,22 +70,6 @@ bool xe_display_driver_probe_defer(struct pci_dev *pdev)
 	return intel_display_driver_probe_defer(pdev);
 }
 
-/**
- * xe_display_driver_set_hooks - Add driver flags and hooks for display
- * @driver: DRM device driver
- *
- * Set features and function hooks in @driver that are needed for driving the
- * display IP. This sets the driver's capability of driving display, regardless
- * if the device has it enabled
- *
- * Note: This is called before xe or display device creation.
- */
-void xe_display_driver_set_hooks(struct drm_driver *driver)
-{
-	if (!xe_modparam.probe_display)
-		return;
-}
-
 static void unset_display_features(struct xe_device *xe)
 {
 	xe->drm.driver_features &= ~XE_DISPLAY_DRIVER_FEATURES;
diff --git a/drivers/gpu/drm/xe/display/xe_display.h b/drivers/gpu/drm/xe/display/xe_display.h
index d2b105d5f2a1..60291cb154df 100644
--- a/drivers/gpu/drm/xe/display/xe_display.h
+++ b/drivers/gpu/drm/xe/display/xe_display.h
@@ -17,7 +17,7 @@ struct xe_device;
 #if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
 
 bool xe_display_driver_probe_defer(struct pci_dev *pdev);
-void xe_display_driver_set_hooks(struct drm_driver *driver);
+
 int xe_display_driver_fbdev_probe(struct drm_fb_helper *fbh,
 				  struct drm_fb_helper_surface_size *sizes);
 
@@ -56,7 +56,6 @@ void xe_display_pm_runtime_resume(struct xe_device *xe);
 	.fbdev_probe = NULL
 
 static inline int xe_display_driver_probe_defer(struct pci_dev *pdev) { return 0; }
-static inline void xe_display_driver_set_hooks(struct drm_driver *driver) { }
 
 static inline int xe_display_probe(struct xe_device *xe) { return 0; }
 
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index c053e4d2692f..7519cda3f42c 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -491,8 +491,6 @@ struct xe_device *xe_device_create(struct pci_dev *pdev,
 		driver = &admin_only_driver;
 #endif
 
-	xe_display_driver_set_hooks(driver);
-
 	err = aperture_remove_conflicting_pci_devices(pdev, driver->name);
 	if (err)
 		return ERR_PTR(err);
-- 
2.47.1


  parent reply	other threads:[~2026-05-12 18:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 18:33 [PATCH 0/7] drm/xe: Make drm_driver const Michal Wajdeczko
2026-05-12 18:33 ` [PATCH 1/7] drm/xe: Drop unused drm/drm_atomic_helper.h include Michal Wajdeczko
2026-05-13  8:56   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 2/7] drm/xe/display: Drop xe_display_driver_remove() stub Michal Wajdeczko
2026-05-13  8:56   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 3/7] drm/xe/display: Prefer forward declarations Michal Wajdeczko
2026-05-13  8:56   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 4/7] drm/xe/display: Add macro with display driver ops Michal Wajdeczko
2026-05-13  8:55   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 5/7] drm/xe/display: Add macro with display driver features Michal Wajdeczko
2026-05-13  9:01   ` Jani Nikula
2026-05-12 18:33 ` Michal Wajdeczko [this message]
2026-05-13  9:01   ` [PATCH 6/7] drm/xe/display: Drop xe_display_driver_set_hooks() Jani Nikula
2026-05-12 18:33 ` [PATCH 7/7] drm/xe: Make drm_driver const Michal Wajdeczko
2026-05-13  9:01   ` Jani Nikula
2026-05-13  3:36 ` ✓ CI.KUnit: success for " Patchwork
2026-05-13  5:12 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-14  1:01 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-14 18:34   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512183342.3374-7-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox