Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 7/7] drm/xe: Make drm_driver const
Date: Wed, 13 May 2026 12:01:42 +0300	[thread overview]
Message-ID: <c16ddcb2146fc981ec7788fce22119746eda7ac1@intel.com> (raw)
In-Reply-To: <20260512183342.3374-8-michal.wajdeczko@intel.com>

On Tue, 12 May 2026, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> After removing runtime modification to our drm_driver definitions,
> we can make them const as they should be.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 7519cda3f42c..576095cf0952 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -391,7 +391,7 @@ bool xe_is_xe_file(const struct file *file)
>  	return file->f_op == &xe_driver_fops;
>  }
>  
> -static struct drm_driver regular_driver = {
> +static const struct drm_driver regular_driver = {
>  	.driver_features =
>  	    XE_DISPLAY_DRIVER_FEATURES |
>  	    DRIVER_GEM |
> @@ -424,7 +424,7 @@ static const struct drm_ioctl_desc xe_ioctls_admin_only[] = {
>  	DRM_IOCTL_DEF_DRV(XE_OBSERVATION, xe_observation_ioctl, DRM_RENDER_ALLOW),
>  };
>  
> -static struct drm_driver admin_only_driver = {
> +static const struct drm_driver admin_only_driver = {
>  	.driver_features =
>  	    XE_DISPLAY_DRIVER_FEATURES |
>  	    DRIVER_GEM | DRIVER_RENDER | DRIVER_GEM_GPUVA,
> @@ -478,7 +478,7 @@ static void xe_device_destroy(struct drm_device *dev, void *dummy)
>  struct xe_device *xe_device_create(struct pci_dev *pdev,
>  				   const struct pci_device_id *ent)
>  {
> -	struct drm_driver *driver = &regular_driver;
> +	const struct drm_driver *driver = &regular_driver;
>  	struct xe_device *xe;
>  	int err;

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-05-13  9:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 18:33 [PATCH 0/7] drm/xe: Make drm_driver const Michal Wajdeczko
2026-05-12 18:33 ` [PATCH 1/7] drm/xe: Drop unused drm/drm_atomic_helper.h include Michal Wajdeczko
2026-05-13  8:56   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 2/7] drm/xe/display: Drop xe_display_driver_remove() stub Michal Wajdeczko
2026-05-13  8:56   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 3/7] drm/xe/display: Prefer forward declarations Michal Wajdeczko
2026-05-13  8:56   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 4/7] drm/xe/display: Add macro with display driver ops Michal Wajdeczko
2026-05-13  8:55   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 5/7] drm/xe/display: Add macro with display driver features Michal Wajdeczko
2026-05-13  9:01   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 6/7] drm/xe/display: Drop xe_display_driver_set_hooks() Michal Wajdeczko
2026-05-13  9:01   ` Jani Nikula
2026-05-12 18:33 ` [PATCH 7/7] drm/xe: Make drm_driver const Michal Wajdeczko
2026-05-13  9:01   ` Jani Nikula [this message]
2026-05-13  3:36 ` ✓ CI.KUnit: success for " Patchwork
2026-05-13  5:12 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-14  1:01 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c16ddcb2146fc981ec7788fce22119746eda7ac1@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox