Re: [PATCH 3/7] drm/xe/display: Prefer forward declarations

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 12 May 2026, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> There is no need to include xe_device.h in the xe_display.h header.
> Include it in the xe_display.c file instead.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> Cc: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 1 +
>  drivers/gpu/drm/xe/display/xe_display.h | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 0747044f7c2a..263e92203c9d 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -36,6 +36,7 @@
>  #include "intel_hotplug.h"
>  #include "intel_opregion.h"
>  #include "skl_watermark.h"
> +#include "xe_device.h"
>  #include "xe_display_bo.h"
>  #include "xe_display_pcode.h"
>  #include "xe_display_rpm.h"
> diff --git a/drivers/gpu/drm/xe/display/xe_display.h b/drivers/gpu/drm/xe/display/xe_display.h
> index fb1db84db966..95acf0fd8e7b 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.h
> +++ b/drivers/gpu/drm/xe/display/xe_display.h
> @@ -6,9 +6,11 @@
>  #ifndef _XE_DISPLAY_H_
>  #define _XE_DISPLAY_H_
>  
> -#include "xe_device.h"
> +#include <linux/types.h>
>  
>  struct drm_driver;
> +struct pci_dev;
> +struct xe_device;
>  
>  #if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)

-- 
Jani Nikula, Intel