intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Don't fall through on DRM_GPUVA_OP_DRIVER in op_check_svm_userptr
@ 2026-07-10 14:12 Mika Kuoppala
  2026-07-10 14:20 ` ✓ CI.KUnit: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Mika Kuoppala @ 2026-07-10 14:12 UTC (permalink / raw)
  To: intel-xe; +Cc: Mika Kuoppala, Matthew Auld

The DRM_GPUVA_OP_DRIVER operation is used by eudebug (and potentially
other driver ops). Because the break was inside the #if GPUSVM block,
we fell through and printed the "NOT POSSIBLE" warning.

Fixes: 7477c4bd20dc ("drm/xe/pt: unify xe_pt_svm_pre_commit with userptr")
Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/xe/xe_pt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index 7111b5d0f6aa..f5ce1fcf484c 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -1547,8 +1547,8 @@ static int op_check_svm_userptr(struct xe_vm *vm, struct xe_vma_op *op,
 			err = vma_check_userptr(vm, gpuva_to_vma(op->base.prefetch.va), pt_update);
 		}
 		break;
-#if IS_ENABLED(CONFIG_DRM_XE_GPUSVM)
 	case DRM_GPUVA_OP_DRIVER:
+#if IS_ENABLED(CONFIG_DRM_XE_GPUSVM)
 		if (op->subop == XE_VMA_SUBOP_MAP_RANGE) {
 			struct xe_svm_range *range = op->map_range.range;
 
@@ -1561,8 +1561,8 @@ static int op_check_svm_userptr(struct xe_vm *vm, struct xe_vma_op *op,
 				return -EAGAIN;
 			}
 		}
-		break;
 #endif
+		break;
 	default:
 		drm_warn(&vm->xe->drm, "NOT POSSIBLE");
 	}
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-07-13 13:19 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10 14:12 [PATCH] drm/xe: Don't fall through on DRM_GPUVA_OP_DRIVER in op_check_svm_userptr Mika Kuoppala
2026-07-10 14:20 ` ✓ CI.KUnit: success for " Patchwork
2026-07-10 15:14 ` [PATCH] " Matthew Auld
2026-07-10 15:28   ` Matthew Auld
2026-07-13 13:19   ` Mika Kuoppala
2026-07-10 15:32 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-07-11  1:07 ` ✓ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).