Re: [PATCH v6 13/18] drm/xe/vsec: Crescent Island PMT decode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused segment mask macros.
--

commit 33d506c12896273e5662ff3cb4664742e398c70e
Author: Michael J. Ruhl <michael.j.ruhl@intel.com>

drm/xe/vsec: Crescent Island PMT decode

This commit updates the PMT decode path and data read callback to support
the Crescent Island (CRI) device, which uses different index and offset
values for accessing the PMT data area.

> diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
> index 031c1c0ae5706..22c4efb021328 100644
> --- a/drivers/gpu/drm/xe/xe_vsec.c
> +++ b/drivers/gpu/drm/xe/xe_vsec.c
> @@ -120,19 +120,25 @@ static struct intel_vsec_platform_info xe_vsec_info[] = {
[ ... ]
>  #define GUID_TELEM_ITERATION	GENMASK(3, 0)
> -#define GUID_SEGMENT		GENMASK(7, 4)
>  #define GUID_SOC_SKU		GENMASK(11, 8)
>  #define GUID_DEVICE_ID		GENMASK(27, 12)
>  #define GUID_CAP_TYPE		GENMASK(29, 28)
>  #define GUID_RECORD_ID		GENMASK(31, 30)
>  
> +#define BMG_GUID_SEGMENT	GENMASK(7, 4)
> +
> +#define CRI_GUID_SEGMENT	GENMASK(5, 4)

[Severity: Low]
Are BMG_GUID_SEGMENT and CRI_GUID_SEGMENT intended to be used? They are
defined here but do not appear to be utilized anywhere in the file or the
rest of the codebase.

> +#define CRI_GUID_INSTANCE	GENMASK(7, 6)
> +
>  #define BMG_IDX_TELEM_PUNIT		0x00

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904182451.1164868-20-michael.j.ruhl@intel.com?part=13