Re: [PATCH v6 04/24] drm/xe: Add job count to GuC exec queue snapshot

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Format specifier mismatch when printing `jobcount`
--

commit bcb5e4e44e3808966c558f04a63143c713dbc759
Author: Matthew Brost <matthew.brost@intel.com>
drm/xe: Add job count to GuC exec queue snapshot

This commit adds the job count to the GuC exec queue snapshot to provide
useful debugging information.

Link: https://patch.msgid.link/20260228013501.106680-5-matthew.brost@intel.com

> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 0a6e2b81b5a53..8b8673f4e037c 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
[ ... ]
> @@ -3756,6 +3757,7 @@ xe_guc_exec_queue_snapshot_print(struct xe_guc_submit_exec_queue_snapshot *snaps
>  	drm_printf(p, "\tLogical mask: 0x%x\n", snapshot->logical_mask);
>  	drm_printf(p, "\tWidth: %d\n", snapshot->width);
>  	drm_printf(p, "\tRef: %d\n", snapshot->refcount);
> +	drm_printf(p, "\tJob count: %d\n", snapshot->jobcount);

[Severity: Low]
Does this code use the wrong format specifier for jobcount?

In xe_guc_submit_types.h, jobcount is declared as an unsigned 32-bit integer
(u32), but it is printed here in xe_guc_exec_queue_snapshot_print() using
the signed %d format specifier instead of %u. While the maximum job count
(1000) easily fits within a signed 32-bit integer, this formally violates
the printf-style format string API constraints.

>  	drm_printf(p, "\tTimeout: %ld (ms)\n", snapshot->sched_timeout);
>  	drm_printf(p, "\tTimeslice: %u (us)\n",
>  		   snapshot->sched_props.timeslice_us);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904211613.3934307-1-matthew.brost@intel.com?part=4