From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Subject: [PATCH v3 13/13] drm/xe/vram: Report VRAM errors using structured xe_log API
Date: Tue, 8 Sep 2026 16:15:50 +0530 [thread overview]
Message-ID: <20260908104550.1283933-14-dnyaneshwar.bhadane@intel.com> (raw)
In-Reply-To: <20260908104550.1283933-1-dnyaneshwar.bhadane@intel.com>
Replace drm_err()/drm_info() with xe_log_err_fatal()/xe_log_info()
using the VRAM component tag. The "no CPU visible VRAM" error uses
tile or device as the log location depending on the caller context.
Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
---
drivers/gpu/drm/xe/xe_vram.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c
index fa06c7ae56b1..6c8558042ad4 100644
--- a/drivers/gpu/drm/xe/xe_vram.c
+++ b/drivers/gpu/drm/xe/xe_vram.c
@@ -17,6 +17,7 @@
#include "xe_device.h"
#include "xe_force_wake.h"
#include "xe_gt_mcr.h"
+#include "xe_log.h"
#include "xe_map.h"
#include "xe_migrate.h"
#include "xe_mmio.h"
@@ -46,7 +47,8 @@ static int determine_lmem_bar_size(struct xe_device *xe, struct xe_vram_region *
struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
if (!resource_is_valid(pdev, LMEM_BAR)) {
- drm_err(&xe->drm, "pci resource is not valid\n");
+ xe_log_err_fatal(xe, VRAM, -ENXIO,
+ "pci resource is not valid\n");
return -ENXIO;
}
@@ -254,8 +256,13 @@ static int vram_region_init(struct xe_device *xe, struct xe_vram_region *vram,
vram->io_size = min_t(u64, usable_size, remain_io_size);
if (!vram->io_size) {
- drm_err(&xe->drm, "%s without any CPU visible VRAM. Aborting.\n",
- tile ? "Tile" : "Device");
+ if (tile) {
+ xe_log_err_fatal(tile, VRAM, -ENODEV,
+ "Tile without any CPU visible VRAM. Aborting.\n");
+ } else {
+ xe_log_err_fatal(xe, VRAM, -ENODEV,
+ "Device without any CPU visible VRAM. Aborting.\n");
+ }
return -ENODEV;
}
@@ -320,7 +327,7 @@ int xe_vram_probe(struct xe_device *xe)
err = determine_lmem_bar_size(xe, &lmem_bar);
if (err)
return err;
- drm_info(&xe->drm, "VISIBLE VRAM: %pa, %pa\n", &lmem_bar.io_start, &lmem_bar.io_size);
+ xe_log_info(xe, VRAM, "VISIBLE VRAM: %pa, %pa\n", &lmem_bar.io_start, &lmem_bar.io_size);
remain_io_size = lmem_bar.io_size;
@@ -342,8 +349,9 @@ int xe_vram_probe(struct xe_device *xe)
return err;
if (total_size > lmem_bar.io_size) {
- drm_info(&xe->drm, "VRAM: %pa is larger than resource %pa\n",
- &total_size, &lmem_bar.io_size);
+ xe_log_info(xe, VRAM,
+ "Total size %pa is larger than resource %pa\n",
+ &total_size, &lmem_bar.io_size);
}
remain_io_size -= min_t(u64, tile->mem.vram->actual_physical_size, remain_io_size);
--
2.54.0
next prev parent reply other threads:[~2026-09-08 10:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 10:45 [PATCH v3 00/13] drm/xe: Convert IO_BUS errors to structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 01/13] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 02/13] drm/xe/ggtt: Report GGTT errors using structured logging Dnyaneshwar Bhadane
2026-09-08 10:57 ` sashiko-bot
2026-09-08 10:45 ` [PATCH v3 03/13] drm/xe/hwmon: Report errors using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 04/13] drm/xe/mmio: Report BAR mapping " Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 05/13] drm/xe/memirq: Report " Dnyaneshwar Bhadane
2026-09-08 10:51 ` sashiko-bot
2026-09-08 10:45 ` [PATCH v3 06/13] drm/xe/reg_whitelist: Report whitelist overflow " Dnyaneshwar Bhadane
2026-09-08 18:12 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 07/13] drm/xe/reg_sr: Report save-restore errors " Dnyaneshwar Bhadane
2026-09-08 18:33 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 08/13] drm/xe/pat: Return error from xe_pat_init_early() on unknown platform Dnyaneshwar Bhadane
2026-09-08 18:37 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 09/13] drm/xe/pat: Report missing PAT table using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 10/13] drm/xe/pci: Report unknown GMDID versions " Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 11/13] drm/xe/lmtt: Report invalidation errors " Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 12/13] drm/xe/vram: Report tile vs device VRAM visibility errors Dnyaneshwar Bhadane
2026-09-08 10:45 ` Dnyaneshwar Bhadane [this message]
2026-09-08 13:17 ` ✓ CI.KUnit: success for drm/xe: Convert IO_BUS errors to structured xe_log API (rev3) Patchwork
2026-09-08 14:21 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-08 18:11 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908104550.1283933-14-dnyaneshwar.bhadane@intel.com \
--to=dnyaneshwar.bhadane@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox