From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Subject: [PATCH v3 03/13] drm/xe/hwmon: Report errors using structured xe_log API
Date: Tue, 8 Sep 2026 16:15:40 +0530 [thread overview]
Message-ID: <20260908104550.1283933-4-dnyaneshwar.bhadane@intel.com> (raw)
In-Reply-To: <20260908104550.1283933-1-dnyaneshwar.bhadane@intel.com>
Replace drm_err() calls with xe_log_err() using the HWMON component
tag to enable structured error reporting with SIGID for hardware
monitor failures:
Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
---
drivers/gpu/drm/xe/xe_hwmon.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
index 5284cab6703d..0f87bd517164 100644
--- a/drivers/gpu/drm/xe/xe_hwmon.c
+++ b/drivers/gpu/drm/xe/xe_hwmon.c
@@ -15,6 +15,7 @@
#include "regs/xe_pcode_regs.h"
#include "xe_device.h"
#include "xe_hwmon.h"
+#include "xe_log.h"
#include "xe_mmio.h"
#include "xe_pcode.h"
#include "xe_pcode_api.h"
@@ -563,9 +564,9 @@ xe_hwmon_power_max_interval_show(struct device *dev, struct device_attribute *at
if (hwmon->xe->info.has_mbx_power_limits) {
ret = xe_hwmon_pcode_read_power_limit(hwmon, power_attr, channel, ®_val);
if (ret) {
- drm_err(&hwmon->xe->drm,
- "power interval read fail, ch %d, attr %d, val 0x%08x, ret %d\n",
- channel, power_attr, reg_val, ret);
+ xe_log_err(hwmon->xe, HWMON, ret,
+ "power interval read fail, ch %d, attr %d, val 0x%08x\n",
+ channel, power_attr, reg_val);
reg_val = 0;
}
} else {
@@ -1599,7 +1600,8 @@ int xe_hwmon_register(struct xe_device *xe)
&hwmon_chip_info,
hwmon_groups);
if (IS_ERR(hwmon->hwmon_dev)) {
- drm_err(&xe->drm, "Failed to register xe hwmon (%pe)\n", hwmon->hwmon_dev);
+ xe_log_err(xe, HWMON, PTR_ERR(hwmon->hwmon_dev),
+ "Failed to register xe hwmon\n");
xe->hwmon = NULL;
return PTR_ERR(hwmon->hwmon_dev);
}
--
2.54.0
next prev parent reply other threads:[~2026-09-08 10:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 10:45 [PATCH v3 00/13] drm/xe: Convert IO_BUS errors to structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 01/13] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 02/13] drm/xe/ggtt: Report GGTT errors using structured logging Dnyaneshwar Bhadane
2026-09-08 10:57 ` sashiko-bot
2026-09-08 10:45 ` Dnyaneshwar Bhadane [this message]
2026-09-08 10:45 ` [PATCH v3 04/13] drm/xe/mmio: Report BAR mapping errors using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 05/13] drm/xe/memirq: Report " Dnyaneshwar Bhadane
2026-09-08 10:51 ` sashiko-bot
2026-09-08 10:45 ` [PATCH v3 06/13] drm/xe/reg_whitelist: Report whitelist overflow " Dnyaneshwar Bhadane
2026-09-08 18:12 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 07/13] drm/xe/reg_sr: Report save-restore errors " Dnyaneshwar Bhadane
2026-09-08 18:33 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 08/13] drm/xe/pat: Return error from xe_pat_init_early() on unknown platform Dnyaneshwar Bhadane
2026-09-08 18:37 ` Michal Wajdeczko
2026-09-08 10:45 ` [PATCH v3 09/13] drm/xe/pat: Report missing PAT table using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 10/13] drm/xe/pci: Report unknown GMDID versions " Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 11/13] drm/xe/lmtt: Report invalidation errors " Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 12/13] drm/xe/vram: Report tile vs device VRAM visibility errors Dnyaneshwar Bhadane
2026-09-08 10:45 ` [PATCH v3 13/13] drm/xe/vram: Report VRAM errors using structured xe_log API Dnyaneshwar Bhadane
2026-09-08 13:17 ` ✓ CI.KUnit: success for drm/xe: Convert IO_BUS errors to structured xe_log API (rev3) Patchwork
2026-09-08 14:21 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-08 18:11 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908104550.1283933-4-dnyaneshwar.bhadane@intel.com \
--to=dnyaneshwar.bhadane@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox