Re: [PATCH v3 05/13] drm/xe/memirq: Report errors using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The memirq_err macro definition is left unused after all its invocations were replaced by xe_log_err.
--

commit 2b3819cee96cee285cc138829c3bd7c1285facac
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/memirq: Report errors using structured xe_log API
    
This commit replaces memirq_err() calls with xe_log_err() using the MEMIRQ
component tag for memory-based IRQ failures.

> diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c
> index 9dfe965cb46ec..32b9f87a10ecf 100644
> --- a/drivers/gpu/drm/xe/xe_memirq.c
> +++ b/drivers/gpu/drm/xe/xe_memirq.c
> @@ -15,6 +15,7 @@
>  #include "xe_gt.h"
>  #include "xe_guc.h"
>  #include "xe_hw_engine.h"
> +#include "xe_log.h"
>  #include "xe_memirq.h"
>  #include "xe_tile_printk.h"
>  

[Severity: Low]
Does this patch leave behind an unused macro definition?

Looking at drivers/gpu/drm/xe/xe_memirq.c, the memirq_err() macro is still
defined but no longer seems to be used after these replacements:

#define memirq_err(m, _fmt, ...)	memirq_printk(m, err, _fmt, ##__VA_ARGS__)

Should this macro definition be removed as well?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908104550.1283933-1-dnyaneshwar.bhadane@intel.com?part=5