Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 0/3] drm/i915/fbc: Dirty rectangle bounding and CFB
@ 2026-09-25 17:36 Austin Hu
  2026-09-25 17:36 ` [PATCH v4 1/3] drm/i915/display/fbc: Move intel_fbc_can_flip_nuke() higher up Austin Hu
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Austin Hu @ 2026-09-25 17:36 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: ville.syrjala, maarten.lankhorst, vinod.govindapillai, huchao426

This series updates Intel FBC dirty rectangle handling and refactors plane
update checks:

1. Moves intel_fbc_can_flip_nuke() higher up in intel_fbc.c to avoid a
   forward declaration in subsequent FBC checks. (No functional change)
2. Clamps FBC dirty rectangle bounds to valid surface limits [y_offset,
   y_end] and adds logging for out-of-bounds coordinates, including
   handling for 180-degree plane rotation.
3. Tracks plane state attribute changes during atomic commits. When FBC
   Dirty Rectangle mode is active, partial updates only apply to surface
   address changes (PLANE_SURF). Modifications to any other plane state
   parameters require fetching full-plane pixel data from memory to
   re-compress and update the entire CFB in stolen memory. Once fully
   re-compressed, subsequent atomic commits can resume selective dirty
   rectangle updates.

v3 -> v4 changes:
  - Rebased onto latest drm-tip.

v2 -> v3 changes:
  - Split function reordering into a separate standalone commit (v3 1/3) to
    avoid mixing movement and functional changes, per maintainer feedback.
  - Rebased onto latest drm-tip.

v1 -> v2 changes:
  - Reused intel_fbc_can_flip_nuke() for plane update state checks as
    suggested.
  - Added plane Y-coordinate plane view checking (color_plane[0].y)
    alongside X.

Austin Hu (2):
  drm/i915/display/fbc: Move intel_fbc_can_flip_nuke() higher up
  drm/i915/fbc: nuke CFB if Plane setting (except for surf addr) changes

Charlton Lin (1):
  drm/i915/fbc: fbc_dirty_rect restrictions and logging

 drivers/gpu/drm/i915/display/intel_fbc.c | 192 +++++++++++++++++------
 1 file changed, 141 insertions(+), 51 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-09-26  4:54 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-25 17:36 [PATCH v4 0/3] drm/i915/fbc: Dirty rectangle bounding and CFB Austin Hu
2026-09-25 17:36 ` [PATCH v4 1/3] drm/i915/display/fbc: Move intel_fbc_can_flip_nuke() higher up Austin Hu
2026-09-25 17:36 ` [PATCH v4 2/3] drm/i915/fbc: fbc_dirty_rect restrictions and logging Austin Hu
2026-09-25 17:52   ` sashiko-bot
2026-09-25 17:36 ` [PATCH v4 3/3] drm/i915/fbc: nuke CFB if Plane setting (except for surf addr) changes Austin Hu
2026-09-25 17:55   ` sashiko-bot
2026-09-25 19:00 ` ✓ CI.KUnit: success for drm/i915/fbc: Dirty rectangle bounding and CFB Patchwork
2026-09-25 19:41 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-26  4:54 ` ✗ Xe.CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox