Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH 5/8] drm/i915/psr: Skip sel fetch support check for invisible planes
Date: Tue, 29 Sep 2026 12:44:31 +0300	[thread overview]
Message-ID: <20260929094434.77129-6-jouni.hogander@intel.com> (raw)
In-Reply-To: <20260929094434.77129-1-jouni.hogander@intel.com>

Calling psr2_sel_fetch_plane_state_supported on an invisible
new_plane_state can trigger unnecessary full update. Avoid this by skipping
the check for invisible plane.

Assisted-by: GitHub-Copilot:claude-sonnet-4.6
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index f2ec7b0e0668c..e2b35b9fee5b2 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -2948,7 +2948,8 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state,
 		    !old_plane_state->uapi.visible)
 			continue;
 
-		if (!psr2_sel_fetch_plane_state_supported(new_plane_state)) {
+		if (new_plane_state->uapi.visible &&
+		    !psr2_sel_fetch_plane_state_supported(new_plane_state)) {
 			full_update = true;
 			break;
 		}
-- 
2.43.0


  parent reply	other threads:[~2026-09-29  9:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29  9:44 [PATCH 0/8] Selective fetch calculation fixes Jouni Högander
2026-09-29  9:44 ` [PATCH 1/8] drm/i915/psr: Clear selective fetch area when duplicating plane state Jouni Högander
2026-09-29  9:44 ` [PATCH 2/8] drm/i915/display: Add enabled pipe planes into state for selective fetch Jouni Högander
2026-09-29  9:44 ` [PATCH 3/8] drm/i915/psr: Disable linked plane sel fetch as well Jouni Högander
2026-09-29  9:44 ` [PATCH 4/8] drm/i915/psr: Fix SFF and CFF CTL register bit definitions Jouni Högander
2026-09-29  9:44 ` Jouni Högander [this message]
2026-09-29  9:44 ` [PATCH 6/8] drm/i915/psr: Don't write 0 size area into plane sel fetch area registers Jouni Högander
2026-09-29  9:44 ` [PATCH 7/8] drm/i915/psr: Remove drm_info_once on failed selective fetch area Jouni Högander
2026-09-29  9:44 ` [PATCH 8/8] drm/i915/psr: Don't clip plane state destination rectangle Jouni Högander
2026-09-29  9:53 ` ✓ CI.KUnit: success for Selective fetch calculation fixes Patchwork
2026-09-29 10:39 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-29 12:11 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260929094434.77129-6-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox