Re: [PATCH 6/9] drm/xe/tests: Set non-GMDID graphics step in xe_pci_fake_device_init()

["Bhadane, Dnyaneshwar" <dnyaneshwar.bhadane@intel.com>]

On 10-Jun-26 1:47 AM, Gustavo Sousa wrote:
> Currently the logic to set the graphics step for non-GMDID-based
> platforms in kunit testing is defined in xe_wa_test_init().  That
> logic should rather belong to the helper xe_pci_fake_device_init(), so
> move it there.
> 
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>

LGTM,
Reviewed-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

> ---
>   drivers/gpu/drm/xe/tests/xe_pci.c     | 3 +++
>   drivers/gpu/drm/xe/tests/xe_wa_test.c | 3 ---
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
> index 1baf3cd0d381..a665d5dbc472 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci.c
> +++ b/drivers/gpu/drm/xe/tests/xe_pci.c
> @@ -388,6 +388,9 @@ int xe_pci_fake_device_init(struct xe_device *xe)
>   	xe_info_init_early(xe, desc, subplatform_desc, &probed_info);
>   	xe_info_init(xe, desc, &probed_info);
>   
> +	if (data && !data->graphics_verx100)
> +		xe->info.step = data->step;
> +
>   	return 0;
>   }
>   EXPORT_SYMBOL_IF_KUNIT(xe_pci_fake_device_init);
> diff --git a/drivers/gpu/drm/xe/tests/xe_wa_test.c b/drivers/gpu/drm/xe/tests/xe_wa_test.c
> index ff0e2502b39f..21601e9df353 100644
> --- a/drivers/gpu/drm/xe/tests/xe_wa_test.c
> +++ b/drivers/gpu/drm/xe/tests/xe_wa_test.c
> @@ -43,9 +43,6 @@ static int xe_wa_test_init(struct kunit *test)
>   		xe_gt_mmio_init(gt);
>   	}
>   
> -	if (!param->graphics_verx100)
> -		xe->info.step = param->step;
> -
>   	/* TODO: init hw engines for engine/LRC WAs */
>   	xe->drm.dev = dev;
>   	test->priv = xe;
>