Re: [PATCH 0/9] drm/xe: Probe info outside of xe_info_init() and xe_info_init_early()

[Gustavo Sousa <gustavo.sousa@intel.com>]

Gustavo Sousa <gustavo.sousa@intel.com> writes:

> Functions xe_info_init() and xe_info_init_early() are meant to
> initialize fields of xe->info, but they also probe the hardware as
> part of the process.  This mixed responsibilities issue makes kunit
> testing need to rely on static stubbing in order to initialize the
> fake device info.
>
> To make the design cleaner, let's do the necessary refactors so that
> those functions don't try to poke the hardware and receive and info
> that needs to be probed as parameters instead.  The end result is that
> functions xe_info_init() and xe_info_init_early() become better
> reusable and we have a cleaner tests/xe_pci.c.
>
> This will also be relevant for an upcoming series that is likely to
> attempt to do fake device initialization outside of tests/xe_pci.c.
> Nevertheless, even without it the refactor is arguably good in itself,
> as observed by the end result of tests/xe_pci.c.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
> Gustavo Sousa (9):
>       drm/xe: Add framework for info probing
>       drm/xe/step: Pass xe_step_info to xe_step_*_get() functions
>       drm/xe: Add devid and revid to xe_probed_info
>       drm/xe/step: Make xe_step_platform_get() independent from xe->info
>       drm/xe: Add platform-level step info to xe_probed_info
>       drm/xe/tests: Set non-GMDID graphics step in xe_pci_fake_device_init()
>       drm/xe: Add graphics/media IPs and their step info to xe_probed_info
>       drm/xe: Don't initialize tile_count in xe_info_init_early()
>       drm/xe: Add tile_count to xe_probed_info

Applied to drm-xe-next. Thank you all for the reviews and feedback!

--
Gustavo Sousa