Re: [PATCH 8/9] drm/xe: Don't initialize tile_count in xe_info_init_early()

["Bhadane, Dnyaneshwar" <dnyaneshwar.bhadane@intel.com>]

On 10-Jun-26 1:47 AM, Gustavo Sousa wrote:
> The value of xe->info.tile_count is only really valid after
> xe_info_probe_tile_count().  Any use of tile_count before that point
> is invalid and, consequently, initializing it in xe_info_init_early()
> is pointless.
> 
> Move the initialization to xe_info_probe_tile_count().
> 
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>

LGTM,
Reviewed-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

> ---
>   drivers/gpu/drm/xe/tests/xe_pci.c |  5 +++--
>   drivers/gpu/drm/xe/xe_pci.c       | 10 ++++++----
>   2 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
> index cd64b1d614c8..31ec41aa997d 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci.c
> +++ b/drivers/gpu/drm/xe/tests/xe_pci.c
> @@ -311,9 +311,10 @@ const void *xe_pci_id_gen_param(struct kunit *test, const void *prev, char *desc
>   }
>   EXPORT_SYMBOL_IF_KUNIT(xe_pci_id_gen_param);
>   
> -static void fake_xe_info_probe_tile_count(struct xe_device *xe)
> +static void fake_xe_info_probe_tile_count(struct xe_device *xe,
> +					  const struct xe_device_desc *desc)
>   {
> -	/* Nothing to do, just use the statically defined value. */
> +	xe->info.tile_count = 1 + desc->max_remote_tiles;
>   }
>   
>   static int fake_probe_info(struct xe_device *xe,
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 388771ef6a52..6b2daad87316 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -811,7 +811,6 @@ static int xe_info_init_early(struct xe_device *xe,
>   	xe_assert(xe, desc->max_gt_per_tile > 0);
>   	xe_assert(xe, desc->max_gt_per_tile <= XE_MAX_GT_PER_TILE);
>   	xe->info.max_gt_per_tile = desc->max_gt_per_tile;
> -	xe->info.tile_count = 1 + desc->max_remote_tiles;
>   
>   	err = xe_tile_init_early(xe_device_get_root_tile(xe), xe, 0);
>   	if (err)
> @@ -823,13 +822,16 @@ static int xe_info_init_early(struct xe_device *xe,
>   /*
>    * Possibly override number of tile based on configuration register.
>    */
> -static void xe_info_probe_tile_count(struct xe_device *xe)
> +static void xe_info_probe_tile_count(struct xe_device *xe,
> +				     const struct xe_device_desc *desc)
>   {
>   	struct xe_mmio *mmio;
>   	u8 tile_count;
>   	u32 mtcfg;
>   
> -	KUNIT_STATIC_STUB_REDIRECT(xe_info_probe_tile_count, xe);
> +	KUNIT_STATIC_STUB_REDIRECT(xe_info_probe_tile_count, xe, desc);
> +
> +	xe->info.tile_count = 1 + desc->max_remote_tiles;
>   
>   	/*
>   	 * Probe for tile count only for platforms that support multiple
> @@ -1035,7 +1037,7 @@ static int xe_info_init(struct xe_device *xe,
>   		xe->info.has_soc_remapper_telem = 0;
>   	}
>   
> -	xe_info_probe_tile_count(xe);
> +	xe_info_probe_tile_count(xe, desc);
>   
>   	for_each_remote_tile(tile, xe, id) {
>   		int err;
>