Re: [PATCH v3 2/2] drm/xe/migrate: fix job lock assert

["Yadav, Arvind" <arvind.yadav@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

Looks good to me.
Reviewed-by: Arvind Yadav <arvind.yadav@intel.com>

On 20-11-2025 18:57, Matthew Auld wrote:
> We are meant to be checking the user vm for the bind queue, but actually
> we are checking the migrate vm. For various reasons this is not
> currently firing but this will likely change in the future.
>
> Now that we have the user_vm attached to the bind queue, we can fix this
> by directly checking that here.
>
> Fixes: dba89840a920 ("drm/xe: Add GT TLB invalidation jobs")
> Signed-off-by: Matthew Auld<matthew.auld@intel.com>
> Cc: Thomas Hellström<thomas.hellstrom@linux.intel.com>
> Cc: Matthew Brost<matthew.brost@intel.com>
> Reviewed-by: Matthew Brost<matthew.brost@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_migrate.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_migrate.c b/drivers/gpu/drm/xe/xe_migrate.c
> index f3b66b55acfb..2ed8ee32b5cf 100644
> --- a/drivers/gpu/drm/xe/xe_migrate.c
> +++ b/drivers/gpu/drm/xe/xe_migrate.c
> @@ -2481,7 +2481,7 @@ void xe_migrate_job_lock(struct xe_migrate *m, struct xe_exec_queue *q)
>   	if (is_migrate)
>   		mutex_lock(&m->job_mutex);
>   	else
> -		xe_vm_assert_held(q->vm);	/* User queues VM's should be locked */
> +		xe_vm_assert_held(q->user_vm);	/* User queues VM's should be locked */
>   }
>   
>   /**
> @@ -2499,7 +2499,7 @@ void xe_migrate_job_unlock(struct xe_migrate *m, struct xe_exec_queue *q)
>   	if (is_migrate)
>   		mutex_unlock(&m->job_mutex);
>   	else
> -		xe_vm_assert_held(q->vm);	/* User queues VM's should be locked */
> +		xe_vm_assert_held(q->user_vm);	/* User queues VM's should be locked */
>   }
>   
>   #if IS_ENABLED(CONFIG_PROVE_LOCKING)

[-- Attachment #2: Type: text/html, Size: 38239 bytes --]