Re: [RFC 07/29] drm/xe/vm: Add an identifier in xe_vma_ops for svm prefetch

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 28-03-2025 04:19, Matthew Brost wrote:
> On Fri, Mar 14, 2025 at 01:32:04PM +0530, Himal Prasad Ghimiray wrote:
>> Add a flag in xe_vma_ops to determine whether it has svm prefetch ops or
>> not.
>>
>> Suggested-by: Matthew Brost <matthew.brost@intel.com>
>> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_vm.c       | 1 +
>>   drivers/gpu/drm/xe/xe_vm_types.h | 3 +++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
>> index 53a80c0af8de..b83154d338c7 100644
>> --- a/drivers/gpu/drm/xe/xe_vm.c
>> +++ b/drivers/gpu/drm/xe/xe_vm.c
>> @@ -3215,6 +3215,7 @@ static void xe_vma_ops_init(struct xe_vma_ops *vops, struct xe_vm *vm,
>>   	vops->q = q;
>>   	vops->syncs = syncs;
>>   	vops->num_syncs = num_syncs;
>> +	vops->flags = false;
> 
> s/false/0 - I this static checkers will complain about this.
> 
> Matt

Thanks. Will address this

> 
>>   }
>>   
>>   static int xe_vm_bind_ioctl_validate_bo(struct xe_device *xe, struct xe_bo *bo,
>> diff --git a/drivers/gpu/drm/xe/xe_vm_types.h b/drivers/gpu/drm/xe/xe_vm_types.h
>> index 93224a87ab03..0b02a37bd2f3 100644
>> --- a/drivers/gpu/drm/xe/xe_vm_types.h
>> +++ b/drivers/gpu/drm/xe/xe_vm_types.h
>> @@ -443,6 +443,9 @@ struct xe_vma_ops {
>>   	u32 num_syncs;
>>   	/** @pt_update_ops: page table update operations */
>>   	struct xe_vm_pgtable_update_ops pt_update_ops[XE_MAX_TILES_PER_DEVICE];
>> +	/** @flag: signify the properties within xe_vma_ops*/
>> +#define XE_VMA_OPS_HAS_SVM_PREFETCH BIT(0)
>> +	u32 flags;
>>   #ifdef TEST_VM_OPS_ERROR
>>   	/** @inject_error: inject error to test error handling */
>>   	bool inject_error;
>> -- 
>> 2.34.1
>>