Re: [RFC 05/29] drm/xe/svm: Make xe_svm_range_* end/start/size public

[Matthew Brost <matthew.brost@intel.com>]

On Fri, Mar 14, 2025 at 01:32:02PM +0530, Himal Prasad Ghimiray wrote:
> These functions will be used in prefetch too, therefore make them public.
> 
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_svm.c | 15 ---------------
>  drivers/gpu/drm/xe/xe_svm.h | 32 ++++++++++++++++++++++++++++++++
>  2 files changed, 32 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
> index 2b041f44730b..07511011aba6 100644
> --- a/drivers/gpu/drm/xe/xe_svm.c
> +++ b/drivers/gpu/drm/xe/xe_svm.c
> @@ -35,21 +35,6 @@ static struct xe_vm *range_to_vm(struct drm_gpusvm_range *r)
>  	return gpusvm_to_vm(r->gpusvm);
>  }
>  
> -static unsigned long xe_svm_range_start(struct xe_svm_range *range)
> -{
> -	return drm_gpusvm_range_start(&range->base);
> -}
> -
> -static unsigned long xe_svm_range_end(struct xe_svm_range *range)
> -{
> -	return drm_gpusvm_range_end(&range->base);
> -}
> -
> -static unsigned long xe_svm_range_size(struct xe_svm_range *range)
> -{
> -	return drm_gpusvm_range_size(&range->base);
> -}
> -
>  #define range_debug(r__, operaton__)					\
>  	vm_dbg(&range_to_vm(&(r__)->base)->xe->drm,			\
>  	       "%s: asid=%u, gpusvm=%p, vram=%d,%d, seqno=%lu, " \
> diff --git a/drivers/gpu/drm/xe/xe_svm.h b/drivers/gpu/drm/xe/xe_svm.h
> index 1af245400799..c8add37614ec 100644
> --- a/drivers/gpu/drm/xe/xe_svm.h
> +++ b/drivers/gpu/drm/xe/xe_svm.h
> @@ -165,6 +165,38 @@ static inline bool xe_svm_range_has_dma_mapping(struct xe_svm_range *range)
>  	return range->base.flags.has_dma_mapping;
>  }
>  
> +/**
> + * xe_svm_range_start() - SVM range start address
> + * @range: SVM range
> + *
> + * Return: start address of range.
> + */
> +static inline unsigned long xe_svm_range_start(struct xe_svm_range *range)
> +{
> +	return drm_gpusvm_range_start(&range->base);
> +}
> +
> +/**
> + * xe_svm_range_start() - SVM range end address
> + * @range: SVM range
> + *
> + * Return: end address of range.
> + */
> +static inline unsigned long xe_svm_range_end(struct xe_svm_range *range)
> +{
> +	return drm_gpusvm_range_end(&range->base);
> +}
> +
> +/**
> + * xe_svm_range_start() - SVM range size
> + * @range: SVM range
> + *
> + * Return: Size of range.
> + */
> +static inline unsigned long xe_svm_range_size(struct xe_svm_range *range)
> +{
> +	return drm_gpusvm_range_size(&range->base);
> +}

Need an extra newline here.

With that:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

>  #define xe_svm_assert_in_notifier(vm__) \
>  	lockdep_assert_held_write(&(vm__)->svm.gpusvm.notifier_lock)
>  
> -- 
> 2.34.1
>