Re: [PATCH 1/2] drm/xe/pcode: Introduce xe_pcode_read_timeout() API

["Poosa, Karthik" <karthik.poosa@intel.com>]

On 31-08-2026 11:02, Tauro, Riana wrote:
>
> On 29-07-2026 22:45, Karthik Poosa wrote:
>> Add the xe_pcode_read_timeout() helper to allow callers to specify
>> custom timeout values for pcode read operations.
>>
>> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_pcode.c | 11 +++++++++++
>>   drivers/gpu/drm/xe/xe_pcode.h |  1 +
>>   2 files changed, 12 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pcode.c 
>> b/drivers/gpu/drm/xe/xe_pcode.c
>> index ccc3bdeed6bb..7386113e60b3 100644
>> --- a/drivers/gpu/drm/xe/xe_pcode.c
>> +++ b/drivers/gpu/drm/xe/xe_pcode.c
>> @@ -147,6 +147,17 @@ int xe_pcode_read(struct xe_tile *tile, u32 
>> mbox, u32 *val, u32 *val1)
>>       return err;
>>   }
>
> Any non-static functions should have a kernel-doc
okay
>
>>   +int xe_pcode_read_timeout(struct xe_tile *tile, u32 mbox, u32 
>> *val, u32 *val1, u32 timeout_ms)
>> +{
>> +    int err;
>
> s/err/ret
>
> Thanks
> Riana
okay, I shall rename it.
>
>> +
>> +    mutex_lock(&tile->pcode.lock);
>> +    err = pcode_mailbox_rw(tile, mbox, val, val1, timeout_ms, true, 
>> false);
>> +    mutex_unlock(&tile->pcode.lock);
>> +
>> +    return err;
>> +}
>> +
>>   static int pcode_try_request(struct xe_tile *tile, u32 mbox,
>>                    u32 request, u32 reply_mask, u32 reply,
>>                    u32 *status, bool atomic, int timeout_us, bool 
>> locked)
>> diff --git a/drivers/gpu/drm/xe/xe_pcode.h 
>> b/drivers/gpu/drm/xe/xe_pcode.h
>> index 8fb3e4ba13a6..c9647c5f305e 100644
>> --- a/drivers/gpu/drm/xe/xe_pcode.h
>> +++ b/drivers/gpu/drm/xe/xe_pcode.h
>> @@ -24,6 +24,7 @@ int xe_pcode_ready(struct xe_device *xe, bool locked);
>>   int xe_pcode_init_min_freq_table(struct xe_tile *tile, u32 
>> min_gt_freq,
>>                    u32 max_gt_freq);
>>   int xe_pcode_read(struct xe_tile *tile, u32 mbox, u32 *val, u32 
>> *val1);
>> +int xe_pcode_read_timeout(struct xe_tile *tile, u32 mbox, u32 *val, 
>> u32 *val1, u32 timeout_ms);
>>   int xe_pcode_write_timeout(struct xe_tile *tile, u32 mbox, u32 val,
>>                  int timeout_ms);
>>   int xe_pcode_write64_timeout(struct xe_tile *tile, u32 mbox, u32 
>> data0,