Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Poosa, Karthik" <karthik.poosa@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>, Raag Jadav <raag.jadav@intel.com>
Cc: "Tauro, Riana" <riana.tauro@intel.com>,
	<intel-xe@lists.freedesktop.org>,  <anshuman.gupta@intel.com>,
	<badal.nilawar@intel.com>, <sk.anirban@intel.com>,
	<mallesh.koujalagi@intel.com>, <soham.purkait@intel.com>
Subject: Re: [PATCH 2/2] drm/xe/hwmon: Increase timeout for mailbox power limits
Date: Mon, 31 Aug 2026 21:57:26 +0530	[thread overview]
Message-ID: <eb8ea8ab-d465-4105-bb1a-db05ddf930ee@intel.com> (raw)
In-Reply-To: <apWIek2rVOLgbTre@intel.com>


On 31-08-2026 19:28, Rodrigo Vivi wrote:
> On Mon, Aug 31, 2026 at 09:41:45AM +0200, Raag Jadav wrote:
>> On Mon, Aug 31, 2026 at 12:39:50PM +0530, Tauro, Riana wrote:
>>> On 31-08-2026 12:24, Poosa, Karthik wrote:
>>>> On 31-08-2026 10:59, Tauro, Riana wrote:
>>>>> On 29-07-2026 22:45, Karthik Poosa wrote:
>>>>>> Mailbox power limit operations can occasionally take longer than the
>>>>>> current 1 ms timeout, causing sporadic failures.
>> Why?
>>
>>>>>> Increase the timeout to 10 ms and rename PL_WRITE_MBX_TIMEOUT_MS to
>>>>>> PL_MBX_TIMEOUT_MS to better reflect its usage.
>>>>> Why is the timeout applicable only for power and not the other
>>>>> attribute reads?
>>>> Because the timeout is seen only with mailbox power limit commands only,
>>>> default 1ms timeout wasn't enough here.
>>> Any reason why this is not seen for the other reads?
>> +1, these things should be coming from a hard spec with valid technical
>> justification and not some random email asking us to do so.
> Well, you have such high expectations :)
> Sometimes we have to live with the empirical... while we hunt other teams asking
> them to do their job correctly, of course...
>
> Interestingly enough, I just found in some of the many spread pcode docs:
>
> driver_to_pcode_mailbox_spec.html#mailbox-response-time
>
> """
> Mailbox response time
> Mailbox response timeout shoudl be set to 10ms as worst case.
> """
>
> Perhaps we should simply change the default to 10ms.

Investigation is ongoing to understand why some pcode mailbox commands 
occasionally take longer to complete.

Until then, using the documented worst-case timeout as default timeout 
seems the better approach.

>
>> Raag

  reply	other threads:[~2026-08-31 16:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 17:15 [PATCH 0/2] drm/xe: Increase timeout for hwmon power limit mailbox operations Karthik Poosa
2026-07-29 17:14 ` ✓ CI.KUnit: success for " Patchwork
2026-07-29 17:15 ` [PATCH 1/2] drm/xe/pcode: Introduce xe_pcode_read_timeout() API Karthik Poosa
2026-08-31  5:32   ` Tauro, Riana
2026-08-31  6:50     ` Poosa, Karthik
2026-07-29 17:15 ` [PATCH 2/2] drm/xe/hwmon: Increase timeout for mailbox power limits Karthik Poosa
2026-08-31  5:29   ` Tauro, Riana
2026-08-31  6:54     ` Poosa, Karthik
2026-08-31  7:09       ` Tauro, Riana
2026-08-31  7:41         ` Raag Jadav
2026-08-31 13:58           ` Rodrigo Vivi
2026-08-31 16:27             ` Poosa, Karthik [this message]
2026-08-31 16:48               ` Rodrigo Vivi
2026-08-31 13:59   ` Rodrigo Vivi
2026-07-29 18:07 ` ✓ Xe.CI.BAT: success for drm/xe: Increase timeout for hwmon power limit mailbox operations Patchwork
2026-07-29 22:58 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb8ea8ab-d465-4105-bb1a-db05ddf930ee@intel.com \
    --to=karthik.poosa@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=sk.anirban@intel.com \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox