Re: [PATCH v2 1/2] drm/xe/guc: Add LFD format output for guc log

["Dong, Zhanjun" <zhanjun.dong@intel.com>]

On 2025-04-11 10:38 a.m., Michal Wajdeczko wrote:
> 
> 
> On 03.04.2025 17:20, Dong, Zhanjun wrote:
>> Please see my inline comments below.
>>
>> Regards,
>> Zhanjun Dong
>>
>> On 2025-03-27 11:39 p.m., Matthew Brost wrote:
>>> On Thu, Mar 27, 2025 at 04:40:27PM -0700, Zhanjun Dong wrote:
>>>> Add new debugfs entry "guc_log_lfd", which supports output guc log
>>>> in LFD(Log Format Descriptors) format.
>>>>
>>>
>>> Not a full review - but couple of drive by comments.
>>>
> 
> ...
> 
>>>> +
>>>> +/** Log Init Config KLV IDs. */
>>>> +enum guc_log_lic_type_t {
>>>
>>> '_t' suffix isn't used in the Xe style as typically is used for typedefs
>>> which are frowned upon in upstream Linux. I'd drop "_t" suffix
>>> everywhere.
>>
>> I agree _t is not Xe style, while for this case, the ABI header file is
>> follows with GuC spec, which is a cross system/project thing. The name
>> here is the secondary defines.
>> I guess simply follows orginal spec will make things more easy to
>> compare and reduce possible mismatches among systems.
>>
> 
> I was also requesting to drop the _t suffix, so it's not just Matt voice
> 
> also please note that the raw GuC spec is not based on some solid ISO
> standard that we should use as a role model, so blindly following what
> was written there is not exactly the right choice
> 
> and while comparing spec you can easily drop _t suffix (that shouldn't
> be there in first place)
> 
> 
No problem, since both of you request to drop it, I will drop it in next 
post

Regards,
Zhanjun Dong