Re: [PATCH v2 1/2] drm/xe/guc: Add LFD format output for guc log

["Dong, Zhanjun" <zhanjun.dong@intel.com>]

On 2025-03-27 11:39 p.m., Matthew Brost wrote:
> On Thu, Mar 27, 2025 at 04:40:27PM -0700, Zhanjun Dong wrote:
>> Add new debugfs entry "guc_log_lfd", which supports output guc log
>> in LFD(Log Format Descriptors) format.
>>
> 
> Not a full review - but couple of drive by comments.
> 
> I suggest trying to split this patch into a series of smaller ones if
> possible. 756 loc is lot for a single patch. Off the top of my head...
> 
> - ABI patches
> - New GuC patch
> - New debugfs entry patch
> 
Thanks for review, I will make another rev which split into more smaller 
ones.

Regards,
Zhanjun

>> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
>> ---
>>   drivers/gpu/drm/xe/abi/guc_log_abi.h     | 112 +++++++
>>   drivers/gpu/drm/xe/abi/guc_log_lfd_abi.h | 261 ++++++++++++++++
>>   drivers/gpu/drm/xe/xe_guc_debugfs.c      |  14 +
>>   drivers/gpu/drm/xe/xe_guc_log.c          | 368 +++++++++++++++++++++++
>>   drivers/gpu/drm/xe/xe_guc_log.h          |   1 +
>>   5 files changed, 756 insertions(+)
>>   create mode 100644 drivers/gpu/drm/xe/abi/guc_log_lfd_abi.h