Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture()
@ 2024-08-16  8:03 apoorva.singh
  2024-08-16  8:07 ` Singh, Apoorva
                   ` (11 more replies)
  0 siblings, 12 replies; 20+ messages in thread
From: apoorva.singh @ 2024-08-16  8:03 UTC (permalink / raw)
  To: intel-xe; +Cc: Apoorva Singh

From: Apoorva Singh <apoorva.singh@intel.com>

- lrc->bo NULL check is not needed in xe_lrc_snapshot_capture() as
  its already been taken care of in xe_lrc_init().

Signed-off-by: Apoorva Singh <apoorva.singh@intel.com>
---
 drivers/gpu/drm/xe/xe_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
index 974a9cd8c379..aec7db39c061 100644
--- a/drivers/gpu/drm/xe/xe_lrc.c
+++ b/drivers/gpu/drm/xe/xe_lrc.c
@@ -1649,7 +1649,7 @@ struct xe_lrc_snapshot *xe_lrc_snapshot_capture(struct xe_lrc *lrc)
 	if (!snapshot)
 		return NULL;
 
-	if (lrc->bo && lrc->bo->vm)
+	if (lrc->bo->vm)
 		xe_vm_get(lrc->bo->vm);
 
 	snapshot->context_desc = xe_lrc_ggtt_addr(lrc);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [PATCH] drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture()
@ 2024-08-16  8:37 apoorva.singh
  0 siblings, 0 replies; 20+ messages in thread
From: apoorva.singh @ 2024-08-16  8:37 UTC (permalink / raw)
  To: intel-xe; +Cc: Apoorva Singh

From: Apoorva Singh <apoorva.singh@intel.com>

lrc->bo NULL check is not needed in xe_lrc_snapshot_capture() as
it is always initialized in xe_lrc_init()

Signed-off-by: Apoorva Singh <apoorva.singh@intel.com>
---
 drivers/gpu/drm/xe/xe_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
index 974a9cd8c379..aec7db39c061 100644
--- a/drivers/gpu/drm/xe/xe_lrc.c
+++ b/drivers/gpu/drm/xe/xe_lrc.c
@@ -1649,7 +1649,7 @@ struct xe_lrc_snapshot *xe_lrc_snapshot_capture(struct xe_lrc *lrc)
 	if (!snapshot)
 		return NULL;
 
-	if (lrc->bo && lrc->bo->vm)
+	if (lrc->bo->vm)
 		xe_vm_get(lrc->bo->vm);
 
 	snapshot->context_desc = xe_lrc_ggtt_addr(lrc);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [PATCH] drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture()
@ 2024-08-16  6:24 apoorva.singh
  2024-08-16  6:26 ` Singh, Apoorva
  0 siblings, 1 reply; 20+ messages in thread
From: apoorva.singh @ 2024-08-16  6:24 UTC (permalink / raw)
  To: intel-xe; +Cc: Apoorva Singh

From: Apoorva Singh <apoorva.singh@intel.com>

- lrc->bo NULL check is not needed in xe_lrc_snapshot_capture() as
  its already been taken care of in xe_lrc_init()y.

Signed-off-by: Apoorva Singh <apoorva.singh@intel.com>
---
 drivers/gpu/drm/xe/xe_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
index 974a9cd8c379..aec7db39c061 100644
--- a/drivers/gpu/drm/xe/xe_lrc.c
+++ b/drivers/gpu/drm/xe/xe_lrc.c
@@ -1649,7 +1649,7 @@ struct xe_lrc_snapshot *xe_lrc_snapshot_capture(struct xe_lrc *lrc)
 	if (!snapshot)
 		return NULL;
 
-	if (lrc->bo && lrc->bo->vm)
+	if (lrc->bo->vm)
 		xe_vm_get(lrc->bo->vm);
 
 	snapshot->context_desc = xe_lrc_ggtt_addr(lrc);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2024-08-26  9:24 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-16  8:03 [PATCH] drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture() apoorva.singh
2024-08-16  8:07 ` Singh, Apoorva
2024-08-16  8:10 ` ✓ CI.Patch_applied: success for drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture() (rev2) Patchwork
2024-08-16  8:10 ` ✓ CI.checkpatch: " Patchwork
2024-08-16  8:11 ` ✓ CI.KUnit: " Patchwork
2024-08-16  8:27 ` ✓ CI.Build: " Patchwork
2024-08-16  8:31 ` ✓ CI.Hooks: " Patchwork
2024-08-16  8:32 ` [PATCH] drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture() Nirmoy Das
2024-08-16  8:33 ` ✓ CI.checksparse: success for drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture() (rev2) Patchwork
2024-08-16  9:11 ` ✗ CI.BAT: failure " Patchwork
2024-08-16 14:00 ` [PATCH] drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture() Rodrigo Vivi
2024-08-16 14:12   ` Nirmoy Das
2024-08-20  9:43   ` Nirmoy Das
2024-08-22 17:23     ` Rodrigo Vivi
2024-08-26  9:24       ` Nirmoy Das
2024-08-16 15:50 ` ✗ CI.FULL: failure for drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture() (rev2) Patchwork
2024-08-16 17:07 ` [PATCH] drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture() Matthew Brost
  -- strict thread matches above, loose matches on Subject: below --
2024-08-16  8:37 apoorva.singh
2024-08-16  6:24 apoorva.singh
2024-08-16  6:26 ` Singh, Apoorva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox