Re: [PATCH 4/5] drm/i915/vrr: Annotate some functions with "hw"

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 9/18/2025 2:04 AM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_vrr_fixed_rr_*() return values that have had the TGL
> SCL adjustment applied to them. So we should indicate that these
> values are only really useful when fed to the hardware. Add
> a "_hw_" indicator to the function names to reflect that fact.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   drivers/gpu/drm/i915/display/intel_vrr.c | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 9cdcc2558ead..71fb64c92165 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -263,7 +263,7 @@ void intel_vrr_compute_vrr_timings(struct intel_crtc_state *crtc_state)
>    * Vtotal value.
>    */
>   static
> -int intel_vrr_fixed_rr_vtotal(const struct intel_crtc_state *crtc_state)
> +int intel_vrr_fixed_rr_hw_vtotal(const struct intel_crtc_state *crtc_state)
>   {
>   	struct intel_display *display = to_intel_display(crtc_state);
>   	int crtc_vtotal = crtc_state->hw.adjusted_mode.crtc_vtotal;
> @@ -276,24 +276,24 @@ int intel_vrr_fixed_rr_vtotal(const struct intel_crtc_state *crtc_state)
>   }
>   
>   static
> -int intel_vrr_fixed_rr_vmax(const struct intel_crtc_state *crtc_state)
> +int intel_vrr_fixed_rr_hw_vmax(const struct intel_crtc_state *crtc_state)
>   {
> -	return intel_vrr_fixed_rr_vtotal(crtc_state);
> +	return intel_vrr_fixed_rr_hw_vtotal(crtc_state);
>   }
>   
>   static
> -int intel_vrr_fixed_rr_vmin(const struct intel_crtc_state *crtc_state)
> +int intel_vrr_fixed_rr_hw_vmin(const struct intel_crtc_state *crtc_state)
>   {
>   	struct intel_display *display = to_intel_display(crtc_state);
>   
> -	return intel_vrr_fixed_rr_vtotal(crtc_state) -
> +	return intel_vrr_fixed_rr_hw_vtotal(crtc_state) -
>   		intel_vrr_flipline_offset(display);
>   }
>   
>   static
> -int intel_vrr_fixed_rr_flipline(const struct intel_crtc_state *crtc_state)
> +int intel_vrr_fixed_rr_hw_flipline(const struct intel_crtc_state *crtc_state)
>   {
> -	return intel_vrr_fixed_rr_vtotal(crtc_state);
> +	return intel_vrr_fixed_rr_hw_vtotal(crtc_state);
>   }
>   
>   void intel_vrr_set_fixed_rr_timings(const struct intel_crtc_state *crtc_state)
> @@ -305,11 +305,11 @@ void intel_vrr_set_fixed_rr_timings(const struct intel_crtc_state *crtc_state)
>   		return;
>   
>   	intel_de_write(display, TRANS_VRR_VMIN(display, cpu_transcoder),
> -		       intel_vrr_fixed_rr_vmin(crtc_state) - 1);
> +		       intel_vrr_fixed_rr_hw_vmin(crtc_state) - 1);
>   	intel_de_write(display, TRANS_VRR_VMAX(display, cpu_transcoder),
> -		       intel_vrr_fixed_rr_vmax(crtc_state) - 1);
> +		       intel_vrr_fixed_rr_hw_vmax(crtc_state) - 1);
>   	intel_de_write(display, TRANS_VRR_FLIPLINE(display, cpu_transcoder),
> -		       intel_vrr_fixed_rr_flipline(crtc_state) - 1);
> +		       intel_vrr_fixed_rr_hw_flipline(crtc_state) - 1);
>   }
>   
>   static